Consider identical display models in ControlConfig
ClosedPublic

Authored by romangg on Nov 18 2018, 11:25 PM.

Details

Summary

Load the correct control information in configurations with identical
displays having the same EDID data by checking additionally the names
of the displays, which are supposed to contain information about the
connectors being used.

Test Plan

Compiles. Auto test passes.

Diff Detail

Repository
R104 KScreen
Branch
1controlNameSpecific
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12735
Build 12753: arc lint + arc unit
romangg created this revision.Nov 18 2018, 11:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2018, 11:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Nov 18 2018, 11:25 PM
mart added a subscriber: mart.Nov 23 2018, 12:12 PM

does this cause incompatibilities with old configs?

romangg updated this revision to Diff 57667.May 6 2019, 5:14 PM

Rebase on series changes.

romangg updated this revision to Diff 57718.EditedMay 7 2019, 1:57 PM
  • Rebase on series changes.
  • Fix autotest
In D16995#364739, @mart wrote:

does this cause incompatibilities with old configs?

No, this is only about the new control files. Config files already differentiate between different connectors. But after thinking about this more I realized there is another issue with old configs, which needs to be solved in another patch of this series:

If there is no control file, the output retention falls back to global. If there is no global file we set some default values. It should instead take the ones from the config file. By that all config files will stay valid until the user first time changes an output property with global retention selected.

romangg updated this revision to Diff 57833.May 9 2019, 11:47 PM

Rebase on series changes.

If there is no control file, the output retention falls back to global. If there is no global file we set some default values. It should instead take the ones from the config file. By that all config files will stay valid until the user first time changes an output property with global retention selected.

Dealt with in new revision of D16991.

romangg updated this revision to Diff 59667.Jun 12 2019, 4:56 PM

Rebase on master.

romangg edited the test plan for this revision. (Show Details)Jun 13 2019, 10:40 AM
romangg updated this revision to Diff 59718.Jun 13 2019, 11:42 AM

Rebase on series changes.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 13 2019, 9:20 PM
This revision was automatically updated to reflect the committed changes.