[SDDM theme] Use the biggest wallpaper resolution
ClosedPublic
Actions

Authored by filipf on Jan 6 2019, 10:54 AM.

Details

Reviewers

Group Reviewers

VDG
Plasma

Maniphest Tasks

T10269: Improve wallpapers

Commits

R120:b9734166ce48: [SDDM theme] Use the biggest wallpaper resolution

Summary

Starting from Plasma 5.16 we have the Next wallpaper is available in 5K resolution so we can make use of it in the login screen as well.

Diff Detail

Repository

R120 Plasma Workspace

Branch

arcpatch-D18007

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12409
Build 12427: arc lint + arc unit

filipf created this revision.Jan 6 2019, 10:54 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 6 2019, 10:54 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

filipf requested review of this revision.Jan 6 2019, 10:54 AM

Harbormaster completed remote builds in B6693: Diff 48785.Jan 6 2019, 10:54 AM

filipf edited the summary of this revision. (Show Details)Jan 6 2019, 10:55 AM

filipf added reviewers: VDG, Plasma.

filipf added a dependency: D18006: Include only the largest size for the "Next" wallpaper.

filipf mentioned this in D18006: Include only the largest size for the "Next" wallpaper.Jan 6 2019, 10:57 AM

ngraham added a task: T10269: Improve wallpapers.Jan 7 2019, 11:24 AM

Now we have an even bigger one! Let's use that.

This revision now requires changes to proceed.Jun 4 2019, 7:25 PM

ngraham removed a dependency: D18006: Include only the largest size for the "Next" wallpaper.Jun 4 2019, 7:25 PM

use 5K instead of 4K

Harbormaster completed remote builds in B12409: Diff 59153.Jun 4 2019, 7:31 PM

filipf edited the summary of this revision. (Show Details)Jun 4 2019, 7:37 PM

filipf edited the summary of this revision. (Show Details)

Needs a rebase before landing as there is a minor merge conflict in the CMake file due to the addition of fontSize=10 in the meantime.

This revision is now accepted and ready to land.Jun 4 2019, 9:05 PM

rebase on master

Harbormaster completed remote builds in B12414: Diff 59159.Jun 4 2019, 9:20 PM

Should we land this in 5.16 as well?

Yes, 5.16 and then merge to master

@davidedmundson was there a reason why we used the very specific 3200x2000 resolution before? Also is this okay?

filipf added a dependency: D21611: [sddm-theme] Set source size for wallpaper.Jun 5 2019, 6:41 PM

Closed by commit R120:b9734166ce48: [SDDM theme] Use the biggest wallpaper resolution (authored by filipf). · Explain WhyJun 5 2019, 8:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			sddm-theme/theme.conf.cmake (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48785	d207995		Jan 6 2019, 10:54 AM	★	★
Diff 2	59153	d207995	use 5K instead of 4K	Jun 4 2019, 7:31 PM	★	★
Diff 3	59159	f6258fa	rebase on master	Jun 4 2019, 9:20 PM	★	★
Diff 4	59228	4280e77	R120:b9734166ce481a664eec6aaaab559a3d7021abf8	Jun 5 2019, 8:33 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a9cd1771c019	6058e1ee1860	d20799548a08	Filip Fila	[SDDM theme] Use the biggest wallpaper resolution (Show More…)	Jun 4 2019, 7:28 PM

	Status	Author	Revision
	Closed	filipf	D18007 [SDDM theme] Use the biggest wallpaper resolution
	Closed	filipf	D21611 [sddm-theme] Set source size for wallpaper

Diff 59153

View Options

sddm-theme/theme.conf.cmake