fix clazy warning
Details
Details
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
core/fileprinter.h | ||
---|---|---|
92 ↗ | (On Diff #56998) | This breaks ABI |
This comment was removed by mlaurent.
Comment Actions
Ok albert send me an email in private :)
he will look at it in several days :)
tha,ks :)
(I didn't have internet access before to see his email :)
Comment Actions
Please revert the QStringLiteral with utf8 inside, after that you can commit if you're convince there will be no regressions :)
autotests/parttest.cpp | ||
---|---|---|
258 | QStringliteral is broken on windows with non ascii chars, please turn this back to QString::fromUtf8 so tests don't start failing. |
autotests/parttest.cpp | ||
---|---|---|
258 | Might be worth a comment so the next person knows? |