Replace event handling with QML Shortcuts and KActionCollection/QAction.
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master-krunnerbashkeybindings (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12181 Build 12199: arc lint + arc unit
Can you explain the rationale behind this? Since you've seemingly randomly changed the shortcut, it doesn't seem like a "common" shortcut sheme?
I tend to frequenty hit additional keys while not watching the runner window. Although the shortcut is no longer in common with Bash (the CTRL + S shortcut would also have made more sense for Bash) the idea is the same. You can already do this from the keyboard, but it requires a select all keycombo AND an arrow key each time you need to jump forward or backwards.
I now see that KDE has default application shortcuts for beginning of line and end of line (HOME and END) and skip word forwards or backwards (CTRL + RARROW/LARROW), that also work in KRunner, that should obsolete this patch.
I don't understand. Also, you can change the default shortcut from Home/End to whatever you like.
Yes, except the CTRL + S combo is default for save in other applications, with no easy way I can think of to reassign it for just KRunner.
Sorry, I'm with Kai on this, aspecially because one of the proposed new shortcuts conflicts with an existing shortcut that it's possible to use here.
Most of the keys on that side of the keyboard are already bound globally into combos, so the best solution IMO is to intercept the required keycombos in KRunner instead of having to rearrange the global app keycombos around KRunner. This is what this patch does to implement bash-style cursor jumps in KRunner, though this is not so great on the HIG front as the intercepted combos are both standard application shortcuts, also duplicating the standard application shortcuts for beginning of line / end of line.
We also have
system settings -> shortcuts -> standard shortcuts
These can have alternatives which would work for this. I don't know if these work with QQC2 TextFields, we should fix it if not.
Thanks for kconfig magic you can override them (without a gui) on a per-app basis albeit there's no UI for that.
Setting alternatives would require unsetting 2 existing default application shortcuts, leaving CTRL-S and CTRL-E unavailable for default actions for other applications. Setting alternatives works for textFields.
Thanks for kconfig magic you can override them (without a gui) on a per-app basis albeit there's no UI for that.
I can't seem to find any information on this.
Perhaps the intent of this patch could change to adding a KShortcutsDialog to the kcm where the MOVETOSTARTOFLINE and MOVETOENDOFLINE keyboard shortcuts could be reassigned?
- [KRunner] Change start of line shortcut to CTRL + S.
- [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.
- Make edit actions configurable.
- Follow standard shortcuts nomenclature.
- Fix clear action.