This implements drawing the various line ending styles for 2 point lines in non-PDF documents.
Looks like this:
CCBUG: 381629
aacid | |
sander |
Okular |
This implements drawing the various line ending styles for 2 point lines in non-PDF documents.
Looks like this:
CCBUG: 381629
No Linters Available |
No Unit Test Coverage |
Buildable 12171 | |
Build 12189: arc lint + arc unit |
Is there an existing class for affien matrix operations?
What about QMatrix or QTransform?
What about QMatrix or QTransform?
Thanks, using QTransform now, it's already widely used in Okular.
Added Butt and Slash. Shorten main line for arrow.
ui/pagepainter.cpp | ||
---|---|---|
450 | The comment below for HighlightAnnotation says MISSING: under/strike width, feather, capping, so it seems the comments had been intended to list annotation sub type features which are not yet implemented. In this case a consistent comment for LineAnnotation would be e.g. MISSING: caption, line endings for multi point lines. Will change it accordingly. |
ui/pagepainter.cpp | ||
---|---|---|
948 | const here and for fImageHeight and penWidth |
Add some const.
Passing QTransform by rvalue reference in LineAnnotPainter::LineAnnotPainter had no special meaning, change it to const reference.
I haven't tested it and haven't tried understanding the code farther than "this is a bunch of painting code".
On the other hand it's "just" painting code, and if it looks like that image, looks good to me.
I'd say give it some time (a week?) in case people want to review and otherwise just commit it.
Rebase on master.
Don't require a Page reference to construct LineAnnotPainter. Knowing the size is enough and makes reuse (e.g. draw preview icons) easier.
Ok, thanks, I'm about to land it and will care for bugfixes if something odd happens. Would anybody accept the revision , for the sake of workflow correctness?
@aacid Are there chances to get MR 269 into poppler in near future? It makes line end drawing more consistent with D21248 and fixes some cases.