| apol |
Since commit a0757af0653 in KContacts, KContacts::PhoneNumber is QMetaType-capable. This has not yet been released, which makes it not ideal for inclusion here. Nevertheless, this is the support we need, so maybe the right answer is to have some clever "ifdef-ing" to make the new code added by this patch not be included if there is a too-old version of KPIM
| No Linters Available |
| No Unit Test Coverage |
| Buildable 12111 | |
| Build 12129: arc lint + arc unit |
Seems like a clear layer break to spill KContacts over KPeople :P.
Let's discuss it at the sprint? Or earlier. Let's discuss it? ^^'
| src/persondata.h | ||
|---|---|---|
| 123 | wrong comment | |
If I understand correctly, the only reason to use KContacts here is so we can use its PhoneNumber type. We could change it to a QString?
It is a string now, the advantage of using the PhoneNumber class is that it has some extra metadata with it (e.g. that you get to know if it's a work or home phone number).