Differential D21341

Call KRunner KRunner
ClosedPublic
Actions

Authored by ngraham on May 22 2019, 2:05 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10966: Unify how we refer to KRunner
Commits
R120:98b53a3667f2: Call KRunner KRunner
Summary

We are currentlly very inconsistent how we refer to KRunner, impairing comprehensibility
among both expert users (who know it as "KRunner") and novice users (for whom "Run
Command" has a literal and somewhat scary meaning).

This patch is a part of T10966: Unify how we refer to KRunner and standardizes on "Show KRunner", helping to turn
KRunner into a user-visible brand name like Apple's Spotlight.

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
call-krunner-krunner (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12078
Build 12096: arc lint + arc unit
ngraham created this revision.May 22 2019, 2:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 22 2019, 2:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 22 2019, 2:05 PM
ngraham edited the test plan for this revision. (Show Details)May 22 2019, 2:06 PM
ndavis accepted this revision.May 22 2019, 6:04 PM
ndavis added a subscriber: ndavis.

Makes sense to me. "Run command" is far too vague. The first time I saw it, I thought it would let me run a command or bash script instead of opening KRunner.

This revision is now accepted and ready to land.May 22 2019, 6:04 PM
ngraham updated this revision to Diff 58499.May 22 2019, 6:12 PM

Found one more

Closed by commit R120:98b53a3667f2: Call KRunner KRunner (authored by ngraham). · Explain WhyMay 22 2019, 6:13 PM
This revision was automatically updated to reflect the committed changes.
mart added a subscriber: mart.Jul 20 2020, 9:54 AM

This was a terrible decision.
KRunner is the worst jargon one can imagine and shouldn't be anywhere in user facing UI

Revision Contents
Changeset List

Diff 58499

View Options

containmentactions/contextmenu/menu.cpp

Loading...
View Options

krunner/view.cpp

Loading...
View Options

lookandfeel/contents/runcommand/RunCommand.qml

Loading...