An inline message with the resulting filename is shown after the screenshot has been successfully saved with a button to open the containing folder. It is also possible to click on the filename to view the image.
Details
- Reviewers
ngraham - Group Reviewers
Spectacle - Commits
- R166:90b214cb4561: Show inline message after image has been saved
Save screenshot and click on the button.The filemanager opens and the saved file is higlighted.
Diff Detail
- Repository
- R166 Spectacle
- Branch
- inline (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12062 Build 12080: arc lint + arc unit
+1, I feel like this makes sense, because in this use case you don't get a notification. Or... maybe it should generate a notification?
If we keep this, I'm not sure a link is the appropriate UI. Typically links are used to go to a website in the user's mind so they might not connect it with the locally-saved file. For this, how about a button in the KMessageWidget saying "Show Containing Folder"? This is done by adding a new QAction to the widget.
I'm not sure about notification vs. messagewidget. Hmm the notification only has a button to open it in an imageviewer. My intention is that after saving I often want to do something with the file which right now is quite tedious manually navigating to the save location. What about clicking the link open the image and having a button to open the folder?
The notification actually does have a way to show it in the file manager. It's in the context menu, which can be accessed using the hamburger button in the corner of the thumbnail, or right-clicking on the thumbnail.
Thanks never knew that. After thinking about it I prefer the InlineMessage. In my mind it's unusual to show a notification for something which is the normal workflow. The purpose of a notification is to get a user's attention that something has happened.
I had the idea while using KMail yesterday actually. If you save an attachment in KMail an InlineMessage is shown (including the Button you described) and I thought to myself "Why doesn't Spectacle have this".
All right cool, let's do it in Spectacle and add a "Show Containing Folder" button in the message instead of a link.
The actions aren't deleted when the message goes away, so if you save three images, you get a message with three buttons in it. :) And if you, say, save an image and then upload it to Imgur, the message continues to have the buttons in it.
Almost perfect. I see one remaining issue: when you click "Copy to clipboard", a message appears that times out in a few seconds. Thereafter, all of the "image saved" messages also time out even though they otherwise don't.
Are you sure? The image saved messages should also time out and do for me too. You just have to wait the time specified in line 371 i.e. 10 seconds.
I see another bug however: If a message is displayed that times out after 10 seconds and inside that time frame (let's say after 8 seconds) another inline message is shown (even if it it should be persistent) the widget hides after 2 seconds. But this bug existed before this patch (i.e with sharing and copying to the clipboard).
Right. But that pre-existing problem becomes more severe the more of these messages we add. I guess we can fix that in another patch though.
Do you have commit access yet?
https://techbase.kde.org/Contribute/Get_a_Contributor_Account
I'll commit this for you now.