Details
- Reviewers
stikonas cjlcarvalho
Diff Detail
- Repository
- R16 KPMCore
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12055 Build 12073: arc lint + arc unit
test/testraid.cpp | ||
---|---|---|
88 ↗ | (On Diff #58541) | Why do we need to mention -1 here? Surely if something is <= 0, then -1 will also satisfy the same condition. |
test/testraid.cpp | ||
---|---|---|
88 ↗ | (On Diff #58541) | -1 means the situation when partition's size can not be computed. |
There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.
And we definitely don't want to use real devices for testing creation. It might make sense to set up temporary loop device as a test disk where we can try to create and then remove RAID.
Add check for mdadm tool
I am still working on this revision.
How can the creation of RAID be tested and what do you mean by loop device?
test/testraid.cpp | ||
---|---|---|
88 ↗ | (On Diff #58651) | In principle I think we should test kpmcore's functionality of raid creation, not mdadm's. Just running mdadm --create will simply print mdadm: an md device must be given in this mode |