The old logic is good but the splitters don't hide
themselves if all children is hidden, so we need to
hide them again.
Details
Details
- Reviewers
ngraham hindenburg - Group Reviewers
Konsole - Commits
- R319:4c39ef39f42b: Fix the logic for Maximize / Minimize
R319:c63cc33e4cc4: Fix the logic for Maximize / Minimize
The terminals seems a bit "cut" after restoration (this actually hits me with anything that shows / hides a session. @hindenburg any hint to fix this behavior completely?
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- fixMaxMinSplitter
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11989 Build 12007: arc lint + arc unit
Comment Actions
This doesn't seem to maximize now. I'm not clear on why the splits need a maximize. I can't figure how to un-maximize the view.
As far as the 'cutting', yes I notice it as well when having text on the screen and doing a split-view. The old code had the same issue.
Comment Actions
Current behavior (that another patch is there to fix) uses two accelerators. one to maximize, another one to restore.
Maximize is ctrl + shift + e, and restore is ctrl + sift + -. I know, horrible shortcuts, but I just compilled and tested, and the behavior is correct now.
The other patch handles transforming this to a toggle, so maximize and restore will work with ctrl + shift + e. (or any other sane shortcut)