[System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI
ClosedPublic

Authored by ngraham on May 7 2019, 9:25 PM.

Details

Summary
  • Port to QQC2+Kirigami FormLayout style, except for the SpinBox which cannot handle decimal values well in the QQC2 version
  • Use standard import names
  • Adjust some strings to sound a bit more natural
Test Plan

Tested with all the variants (CPU, network, etc). All features still work and settings
are saved and loaded properly.

Diff Detail

Repository
R120 Plasma Workspace
Branch
systemmonitor-modernize-settings-page (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11676
Build 11694: arc lint + arc unit
ngraham created this revision.May 7 2019, 9:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 7 2019, 9:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 7 2019, 9:25 PM
filipf added a subscriber: filipf.May 8 2019, 8:29 PM
filipf added inline comments.
applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
116

We should do anchors.left: parent.left and anchors.right: parent.right here so the layout is horizontally centered.

124

Should be "Update interval:" afaik

ngraham updated this revision to Diff 57780.May 8 2019, 8:43 PM
ngraham marked 2 inline comments as done.

Address review comments

filipf accepted this revision.May 8 2019, 8:43 PM
This revision is now accepted and ready to land.May 8 2019, 8:43 PM
This revision was automatically updated to reflect the committed changes.