[Task Manager] Use libnotificationmanager for notification badges and application job reporting
ClosedPublic

Authored by broulik on May 7 2019, 7:57 AM.

Details

Summary

This removes the setting from the individual plasmoid and has it follow global settings in the new KCM.
Since the new JobsModel also emits application jobs via the Unity launcher API, the codepath for dealing with jobs is dropped and instead it only listens to Unity signals now.

Test Plan

Depends on D20265
Do not disturb mode doesnt auto expire as I dont check the time periodically (might slap in the time dataengine like I do in notifications). It cannot tell between genuine badges and job badges, so when you disable job tracking you stil get a badge of "1" thing going on. Also, since the setting is global now, the smart launcher stuff is always loaded but it's just one more qobject per task and the QML bits for progress and badges are behind loaders already, only loading when there is a progress or badge to be displayed.

Other than that, works well, even with Latte Dock.

  • Copied files in dolphin, progress showed up
  • Set a badge on an app, showed up
  • Changed settings, they updated the thing live. Disabled notification jobs, task manager jobs still showed up and vice-versa. Disabled both, next job got the fallback widget dialog. Enabled task settings again, next job would use it again.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 7 2019, 7:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 7 2019, 7:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 7 2019, 7:57 AM
broulik updated this revision to Diff 57697.May 7 2019, 8:00 AM
broulik edited the test plan for this revision. (Show Details)
  • Read correct setting for enabling/disabling jobs
mart accepted this revision.May 8 2019, 1:53 PM
This revision is now accepted and ready to land.May 8 2019, 1:53 PM
This revision was automatically updated to reflect the committed changes.