[desktoppackage] Port to QQC2 and fix "Get New Widgets..." button text
ClosedPublic

Authored by GB_2 on Apr 29 2019, 5:00 PM.

Details

Summary
  • Port to QQC2
  • Fix "Get New Widgets..." button text
Test Plan

Try pressing Esc in the widget explorer dialog or alternatives dialog or in the panel edit mode. Also look at the "Get New Widgets..." button in the widget explorer dialog.

Diff Detail

Repository
R119 Plasma Desktop
Branch
desktoppackage-port-to-qqc2-and-fix-get-new-widgets-button-text (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11355
Build 11373: arc lint + arc unit
GB_2 created this revision.Apr 29 2019, 5:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 29 2019, 5:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Apr 29 2019, 5:00 PM
ngraham added a subscriber: ngraham.

I would not even change QQC and QtControls to QQC2. That way the diff will be even smaller.

GB_2 added a comment.Apr 29 2019, 5:05 PM

I would not even change QQC and QtControls to QQC2. That way the diff will be even smaller.

Is the diff being smaller more important than making it consistent?

I don't think we do have a consistent style for the import name. In some places it's QQC2, in others it's QtControls, or QtControls2, or nothing at all (as in WidgetExplorer.qml). Also we mostly don't add a name for the Layouts import, but in a few places we do. Etc. I'm not sure it really matters, but if we want to make this consistent we should settle on something to be consistent with first. :)

GB_2 updated this revision to Diff 57207.Apr 29 2019, 5:16 PM

Add QQC2 import name where it was missing

ngraham accepted this revision.Apr 29 2019, 5:37 PM
This revision is now accepted and ready to land.Apr 29 2019, 5:37 PM
This revision was automatically updated to reflect the committed changes.