find cantor via config (and fall back to finder when not available)
ClosedPublic

Authored by sitter on Apr 25 2019, 1:16 PM.

Details

Summary

this is fully backwards compatible but has the advantage that it

  • shows up in cmake feature summary
  • will use the config when it is available (which is at least since 19.04)
Test Plan

still builds

Diff Detail

Repository
R262 LabPlot
Branch
cantor
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11331
Build 11349: arc lint + arc unit
sitter created this revision.Apr 25 2019, 1:16 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 25 2019, 1:16 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sitter requested review of this revision.Apr 25 2019, 1:16 PM
apol added a subscriber: apol.Apr 25 2019, 3:30 PM

Other than that, +1 for the patch.

cmake/FindCantor.cmake
37

Can we add a config.cmake file? aren't labplot and cantor released together?

cfeck added a subscriber: cfeck.Apr 25 2019, 3:39 PM

No, LabPlot is not part of the KDE Applications bundle.

apol added a comment.Apr 25 2019, 3:44 PM

Then let's leave it as +1 :)

asemke added a subscriber: asemke.Apr 28 2019, 8:55 AM
asemke added inline comments.
src/CMakeLists.txt
377

what is this needed for?

sitter added inline comments.Apr 29 2019, 9:13 AM
src/CMakeLists.txt
377

Mhhh. Good catch. It's unrelated noise.

sitter updated this revision to Diff 57163.Apr 29 2019, 9:49 AM

throw out some noise

asemke accepted this revision.May 10 2019, 4:14 PM
This revision is now accepted and ready to land.May 10 2019, 4:14 PM
This revision was automatically updated to reflect the committed changes.