Differential D20818

Add the Show Desktop applet (moved from kdeplasma-addons)
ClosedPublic
Actions

Authored by GB_2 on Apr 25 2019, 2:48 PM.

Details

Reviewers

ngraham
apol

Group Reviewers

Plasma
VDG

Maniphest Tasks

T7917: Show Desktop widget should be present by default in new installs

Commits

R119:b6d785370d53: Add the Show Desktop applet (moved from kdeplasma-addons)

Summary

Move the Show Desktop applet from kdeplasma-addons to plasma-desktop, so it can be added to the panel by default later.

Test Plan

The Show Desktop applet should now appear in the "Add Widgets..." dialog when kdeplasma-addons is not installed.

Diff Detail

Repository

R119 Plasma Desktop

Branch

arcpatch-D20818

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11257
Build 11275: arc lint + arc unit

GB_2 created this revision.Apr 25 2019, 2:48 PM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 25 2019, 2:48 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

GB_2 requested review of this revision.Apr 25 2019, 2:48 PM

Harbormaster completed remote builds in B11224: Diff 56973.Apr 25 2019, 2:48 PM

GB_2 added a dependent revision: D20817: Remove the Show Desktop applet (it's in plasma-desktop now).Apr 25 2019, 2:48 PM

GB_2 added a dependency: D20820: Add Show Desktop applet to default panel.Apr 25 2019, 2:59 PM

GB_2 removed a dependency: D20820: Add Show Desktop applet to default panel.

GB_2 added a dependent revision: D20820: Add Show Desktop applet to default panel.

ngraham retitled this revision from [plasma-desktop] Move the Show Desktop applet to [plasma-desktop] Add the Show Desktop applet (moved from kdeplasma-addons).Apr 25 2019, 3:25 PM

ngraham retitled this revision from [plasma-desktop] Add the Show Desktop applet (moved from kdeplasma-addons) to Add the Show Desktop applet (moved from kdeplasma-addons).Apr 25 2019, 3:34 PM

Nice. Please wait for a Plasma review too. :)

This revision is now accepted and ready to land.Apr 25 2019, 3:37 PM

ngraham added a task: T7917: Show Desktop widget should be present by default in new installs.Apr 25 2019, 3:37 PM

Looks good to me. Will have to move the (few) translations with it. @ltoscano

Thanks, I will keep an eye on the review.

Does that mean I can land it?

Move Minimize All too, so there is an alternative

Harbormaster completed remote builds in B11257: Diff 57040.Apr 26 2019, 1:42 PM

ngraham accepted this revision.Apr 26 2019, 3:29 PM

Closed by commit R119:b6d785370d53: Add the Show Desktop applet (moved from kdeplasma-addons) (authored by GB_2). · Explain WhyApr 26 2019, 5:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		applets/CMakeLists.txt (2 lines)
A	M	applets/minimizeall/CMakeLists.txt (2 lines)
A	M	applets/minimizeall/Messages.sh (2 lines)
A	M	applets/minimizeall/package/contents/config/main.xml (13 lines)
A	M	applets/minimizeall/package/contents/ui/main.qml (172 lines)
A	M	applets/minimizeall/package/metadata.desktop (93 lines)
A	M	applets/showdesktop/CMakeLists.txt (20 lines)
A	M	applets/showdesktop/Messages.sh (2 lines)
A	M	applets/showdesktop/package/contents/config/main.xml (13 lines)
A	M	applets/showdesktop/package/contents/ui/main.qml (91 lines)
A	M	applets/showdesktop/package/metadata.desktop (133 lines)
A	M	applets/showdesktop/plugin/qmldir (2 lines)
A	M	applets/showdesktop/plugin/showdesktop.h (43 lines)
A	M	applets/showdesktop/plugin/showdesktop.cpp (46 lines)
A	M	applets/showdesktop/plugin/showdesktopplugin.h (35 lines)
A	M	applets/showdesktop/plugin/showdesktopplugin.cpp (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56973	a416f16		Apr 25 2019, 2:48 PM	★	★
Diff 2	57040	a416f16	Move Minimize All too, so there is an alternative	Apr 26 2019, 1:42 PM	★	★
Diff 3	57057	b6b008b	R119:b6d785370d53dbfbdbd3ee462ccdf34fead24ba5	Apr 26 2019, 5:06 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
04dcb5810684	69d9b63ac78a	a416f16b562b	Björn Feber	Add the Show Desktop applet (moved from kdeplasma-addons) (Show More…)	Apr 26 2019, 1:41 PM

Status	Author	Revision
Closed	GB_2	D20817 Remove the Show Desktop applet (it's in plasma-desktop now)
Closed	GB_2	D20820 Add Show Desktop applet to default panel
Closed	GB_2	D20818 Add the Show Desktop applet (moved from kdeplasma-addons)