I saw it being checked like that, I think it reads a bit cleaner.
Details
Details
Diff Detail
Diff Detail
- Repository
- R289 KNotifications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11244 Build 11262: arc lint + arc unit
src/knotificationmanager.cpp | ||
---|---|---|
94–95 | Do you need this check now, even, since you're not using it anymore? |
Comment Actions
We still use it to check whether to initialise portalDBusServiceExists. I'll simplify it a bit.
Comment Actions
Lookgs good to me, I'll wait for Kai to approve this since he is the maintainer. One thing to consider maybe, did /.flatpak-info always exist or is it something new? I always assumed there is just one flatpak-info file in $XDG_RUNTIME_DIR. Just to be sure it will work for older Flatpak versions.
src/knotificationmanager.cpp | ||
---|---|---|
94–95 | I think Kai is right, since there is /.flatpak-info (which I didn't know about until now), you don't need to check $XDG_RUNTIME_DIR. |