[kcmkwin/kwintabbox] Use a more appropriate icon
ClosedPublic

Authored by ngraham on Apr 25 2019, 2:18 AM.

Details

Summary

The current icon (window-duplicate) is semantically incorrect and visually disconnected from what it actually does.

This one is much more appropriate on both counts.

Test Plan

Diff Detail

Repository
R108 KWin
Branch
better-tabbox-kcm-icon (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11211
Build 11229: arc lint + arc unit
ngraham created this revision.Apr 25 2019, 2:18 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 25 2019, 2:18 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
ngraham requested review of this revision.Apr 25 2019, 2:18 AM
zzag added a subscriber: zzag.Apr 25 2019, 7:38 AM
zzag added inline comments.
kcmkwin/kwintabbox/kwintabbox.desktop
4

Is this icon choice good though? It would be great to have some alias (e.g. preferences-desktop-tabbox -> preferences-system-windows-effect-flipswitch) and use it instead.

ngraham updated this revision to Diff 56957.Apr 25 2019, 1:11 PM
ngraham marked an inline comment as done.

Use a more generically appropriate icon name

zzag accepted this revision.Apr 25 2019, 1:17 PM
This revision is now accepted and ready to land.Apr 25 2019, 1:17 PM
This revision was automatically updated to reflect the committed changes.