process: add NoNewPrivileges
ClosedPublic

Authored by topimiettinen on Apr 17 2019, 7:39 PM.

Details

Summary

Signed-off-by: Topi Miettinen <toiwoton@gmail.com>

Diff Detail

Repository
R111 KSysguard Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11171
Build 11189: arc lint + arc unit
topimiettinen created this revision.Apr 17 2019, 7:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2019, 7:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
topimiettinen requested review of this revision.Apr 17 2019, 7:39 PM

FYI, you can update an old phabricator request with new changes. Arc should should do it automatically if the phabricator line is in the commit message.

We've now set the change flag, but I would still expect a line around processmodel.cpp:750

if(process->changes() & KSysGuard::Process::Status) {
     totalUpdated++;
     QModelIndex index = q->createIndex(row, ProcessModel::HeadingNoNewPrivileges process);
     emit q->dataChanged(index, index);
 }

Updated per comments from @davidedmundson.

update also remote protocol

davidedmundson accepted this revision.Apr 24 2019, 8:37 AM
This revision is now accepted and ready to land.Apr 24 2019, 8:37 AM

Do you have KDE commit access?

Do you have KDE commit access?

No, I only started hacking KDE a few days ago...

I can land it for you now since you used arc to submit the patch. :)

This revision was automatically updated to reflect the committed changes.

Can you please make sure this column isn't enabled by default? After updating this morning I suddenly had an "NNP" column I didn't ask for or knew what it was