Differential D20658

GCompris multiply activity : replace the "x" sign by the unicode times sign
ClosedPublic
Actions

Authored by christophec on Apr 18 2019, 12:30 PM.

Details

Reviewers

Maniphest Tasks

T10808: Multiplication activity : replace letter "x" by multiplication sign

Summary

Replaced all operand signs by their correponding unicode values. "x" is letter x, not times sign and looked strange with some fonts.
Change was done in all algebra activities (+, -, x, /).

Test Plan

Look in all algebra activities if sign is displayed correctly and if their are no other impacts in those activities.

Diff Detail

Repository

R2 GCompris

Lint

Lint Skipped

Unit

Unit Tests Skipped

christophec created this revision.Apr 18 2019, 12:30 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 18 2019, 12:30 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

christophec requested review of this revision.Apr 18 2019, 12:30 PM

christophec added a task: T10808: Multiplication activity : replace letter "x" by multiplication sign.Apr 18 2019, 12:39 PM

Thank you! Seems good to me, I'll test it tonight and push it if it works fine

This revision is now accepted and ready to land.Apr 18 2019, 2:09 PM

Can you please provide your email so I can set you as author of the commit?

Sorry, I don't understand... Where do you want me to provide my email ?

In D20658#452734, @christophec wrote:

Sorry, I don't understand... Where do you want me to provide my email ?

It is impossible to commit changes without email in the git --author option due to KDE hooks.

Just leave it here in the comment.

For other considerations on anonymous commits, please read this thread:

https://mail.kde.org/pipermail/kde-community/2019q2/005296.html

Ok, thanks for the explanation ! My email is christophe.chabanois@laposte.net

Thank you (and Yuri for the explanation), it's commited in https://cgit.kde.org/gcompris.git/commit/?id=930060c5810b0b5004ef561829b3891e0909641a

Revision Contents
Changeset List

			Path	Packages
M			src/activities/algebra_by/AlgebraBy.qml (3 lines)
M			src/activities/algebra_by/algebra.js (24 lines)
M			src/activities/algebra_div/AlgebraDiv.qml (3 lines)
M			src/activities/algebra_minus/AlgebraMinus.qml (4 lines)
M			src/activities/algebra_plus/AlgebraPlus.qml (3 lines)