[Kickoff] Modernize settings window layout
ClosedPublic

Authored by ngraham on Apr 16 2019, 9:38 PM.

Details

Summary

In this patch, the settings window is modernized in the following ways:

  • Adopt Kirigami+FormLayout style
  • Port away from QQC2
  • Make the tab switcher UI take up less horizontal space, so the buttons don't get cut off at the default window size
Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
kickoff-settings-layout-update (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10966
Build 10984: arc lint + arc unit
ngraham created this revision.Apr 16 2019, 9:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 16 2019, 9:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 16 2019, 9:38 PM

+1

applets/kickoff/package/contents/ui/ConfigGeneral.qml
42–43

Did you try Layout.preferredHeight?

51

I was wondering, while at it, can we make the menu open onPressed to be consistent with all other menus and buttons with menus?

ngraham updated this revision to Diff 56458.Apr 17 2019, 5:27 PM
ngraham marked 2 inline comments as done.

Use onPressed And Layout.preferredHeight (still doesn't fix the button height though)

GB_2 added a subscriber: GB_2.Apr 17 2019, 6:21 PM

Use onPressed And Layout.preferredHeight (still doesn't fix the button height though)

Just use implicitWidth and implicitHeight.

filipf added a subscriber: filipf.Apr 18 2019, 2:41 PM
In D20612#452054, @GB_2 wrote:

Use onPressed And Layout.preferredHeight (still doesn't fix the button height though)

Just use implicitWidth and implicitHeight.

+1 this fixes the button

Some other comments:

  • it's not correct for the configuration category to be called Appearance; we have behavior checkboxes present -> we can just call the category "General"
  • we need to add isSection spacing underneath the icon -> looks different in my screenshot than in the test plan for some reason:

  • the Kirigami headings for config buttons could use some vertical padding IMO
ngraham updated this revision to Diff 56550.Apr 18 2019, 4:30 PM
  • Fix button height issue
  • Add padding between sections
  • Add vertical spacing between button categories
  • Rename to "General" and use appropriate icon
ngraham retitled this revision from [RFC] [Kickoff] Modernize settings window layout to [Kickoff] Modernize settings window layout.Apr 18 2019, 4:30 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
filipf accepted this revision.Apr 18 2019, 8:44 PM

Nice! The last label is getting cut off for me with the default window size, but not sure what could be done about it.

This revision is now accepted and ready to land.Apr 18 2019, 8:44 PM
filipf added inline comments.Apr 18 2019, 8:58 PM
applets/kickoff/package/contents/ui/ConfigButtons.qml
29

maybe units.smallSpacing would be enough, what do you think?

ngraham added inline comments.Apr 18 2019, 9:03 PM
applets/kickoff/package/contents/ui/ConfigButtons.qml
29

Yeah, good call

ngraham updated this revision to Diff 56561.Apr 18 2019, 9:04 PM

largeSpacing -> smallSpacing

ngraham edited the test plan for this revision. (Show Details)Apr 18 2019, 9:04 PM
ngraham marked 2 inline comments as done.
filipf accepted this revision.Apr 18 2019, 9:05 PM
hein accepted this revision.Apr 22 2019, 3:26 PM
hein added a subscriber: hein.

LGTM.

This revision was automatically updated to reflect the committed changes.