Add new notification plasmoid
ClosedPublic

Authored by broulik on Apr 5 2019, 1:34 PM.
Tags
Subscribers
Tokens
"Party Time" token, awarded by ognarb."Love" token, awarded by meven."Like" token, awarded by Ghost6."Burninate" token, awarded by filipf."Like" token, awarded by chinmoyr."Like" token, awarded by alexeymin."Orange Medal" token, awarded by mmustac."Party Time" token, awarded by ngraham."Love" token, awarded by GB_2.

Details

Reviewers
mart
Group Reviewers
Plasma
VDG
Summary

This completely rewrites the notification plasmoid using libnotificationmanager

The popups are much more compact and persistent notifications stay on screen now until dismissed. The is also only one global set of popups, rather than one per applet.
Job progress is merged into notifications for a unified look, with a sensible summary text containing the most important infos about a job.
A do not disturb toggle is added that allows to set a time in which no notification popups or sounds are played and all notifications go straight to the history.
The history will ignore notifications that were explicitly closed or interacted with and will be grouped by app and show only 2 notifications per app by default to be less cluttered.

BUG: 222470
BUG: 402144
BUG: 405570
BUG: 391646
BUG: 401819
BUG: 400811
BUG: 392669
BUG: 390143
BUG: 390864
BUG: 374099
BUG: 360990
BUG: 346458
BUG: 398926
BUG: 390152
BUG: 342355
CCBUG: 402391
CCBUG: 399697
CCBUG: 400871
CCBUG: 398580
FIXED-IN: 5.16.0

Test Plan

Depends on D20265

(hope I didnt mistype any of the bugs)

Let the screenshots speak for themselves...

Much more compact, more refined look:


Thumbnail are touched up with better apsect ratio and blur:

Can also be very compact if no summary is provided

History popup with no notifiations

Do not disturb time selection (today is Friday so it offers next Monday as end time)

Do not disturb for 1 hour

History full of notifications, expand feature

Collapse feature

Single notification amongst a group

Better job dialogs, providing the most important info at a glance

Full details still available

Again, most important info (how many of how many and where is it going) right there without having to expand details section

Copying multiple files finished offers to open the destination folder

Copying/Downloading single file offers to act on the file like you can with screenshots

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 5 2019, 1:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 5 2019, 1:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 5 2019, 1:34 PM
GB_2 awarded a token.Apr 5 2019, 1:44 PM
GB_2 added a subscriber: GB_2.Apr 5 2019, 1:47 PM

Amazing!

applets/notifications/package/contents/ui/FullRepresentation.qml
248

Please remove the dot to make it consistent with other Plasmoids.

filipf awarded a token.Apr 5 2019, 4:27 PM
ngraham added a subscriber: ngraham.Apr 5 2019, 4:52 PM

This UI is fantastic. A huge improvement over the status quo.

It seems like there's no Do Not Disturb mode that stays on until manually turned off though?

abetts added a subscriber: abetts.Apr 5 2019, 4:57 PM

This UI is fantastic. A huge improvement over the status quo.

It seems like there's no Do Not Disturb mode that stays on until manually turned off though?

I was thinking too that where the label "Do not disturb" is located, when you turn on any of the time features, it could be like this

  • Do not disturb "12 min remaining"
  • Do not disturb "until disabled"

Maybe having Do Not Disturb for a custom amount of time would also be helpful in case none of the options fit the user?

Just tossing ideas

meven awarded a token.Apr 5 2019, 5:49 PM
GB_2 added a comment.Apr 5 2019, 6:20 PM
This comment was removed by GB_2.
ognarb awarded a token.Apr 7 2019, 2:11 PM

It seems like there's no Do Not Disturb mode that stays on until manually turned off though?

Yeah. I can add that, I guess. What should that menu entry look like?

It seems like there's no Do Not Disturb mode that stays on until manually turned off though?

Yeah. I can add that, I guess. What should that menu entry look like?

Something like this:

    Do Not Disturb
For 1 hour
Until this evening
Until tomorrow morning
Until Monday
Until manually turned off

While you're at it, for 4 hours would be nice too. Telegram has that and I find myself using it a lot more than For 1 hour. The use case is basically, "disable all these after-lunch notifications until I'm done with work". Then again Until this evening might cover that case adequately, depending on what "evening" actually means. It might be nice to replace that ambiguous term with the actual time (i.e. Until 8 PM tonight or something).

broulik updated this revision to Diff 56057.Apr 12 2019, 11:46 AM
  • Grouping fixes, unread notifications are automatically expanded now and collapsing a group scrolls to the top of it
  • Added "4 hours" and "until disabled" do not disturb mode
  • Job progress bar is hidden when completed
  • Minor fixes
broulik updated this revision to Diff 56059.Apr 12 2019, 11:47 AM
  • Fix diff screwup
broulik edited the test plan for this revision. (Show Details)Apr 12 2019, 11:50 AM
mart accepted this revision.Apr 24 2019, 1:32 PM
mart added a subscriber: mart.
mart added inline comments.
applets/notifications/package/contents/ui/CompactRepresentation.qml
102

fontsizemode isn't used there, remove comment?

This revision is now accepted and ready to land.Apr 24 2019, 1:32 PM