Differential D14200

Simplify newSession code
Needs ReviewPublic
Actions

Authored by tcanabrava on Jul 18 2018, 9:06 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Summary

This time I did not removed the function calls, just
forwarded the calls to the most complete one.
Removing the function calls and adding default parameters
did not seem to work well with dbus

Diff Detail

Repository
R319 Konsole
Branch
arcpatch-D14200
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10664
Build 10682: arc lint + arc unit
tcanabrava created this revision.Jul 18 2018, 9:06 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 18 2018, 9:06 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jul 18 2018, 9:06 AM
tcanabrava abandoned this revision.Aug 28 2018, 3:00 PM

Stale for too long.

tcanabrava reclaimed this revision.Sep 9 2018, 4:19 PM
hindenburg added inline comments.Feb 15 2019, 3:46 PM
src/ViewManager.cpp
974

simpler toalso add the , QString() as below?

tcanabrava updated this revision to Diff 55823.Apr 9 2019, 2:41 PM
  • Further simplify code
hindenburg added a comment.Apr 10 2019, 2:06 PM

Something not correct as it doesn't actually start a new session.

hindenburg added a comment.Apr 10 2019, 2:09 PM

Oh this is actually broken in master. So this patch might be OK once that's fixed.

tcanabrava added subscribers: gennad, thsurrel.Apr 10 2019, 2:13 PM

I beg your pardon? (How do I test the new session? konsole is working
for me so maybe it's something I missed)

hindenburg added a comment.Apr 10 2019, 2:17 PM

qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_WINDOW newSession test1 /tmp

and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0

printenv | grep KONSOLE

hindenburg added a comment.Apr 10 2019, 2:27 PM
In D14200#447412, @hindenburg wrote:

and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0

Well sometimes it is set and sometimes not

tcanabrava added a comment.Apr 10 2019, 2:29 PM

We set this variable in two or three different files and in a few different
methods. I remember that one of the first things that I tried to do for
konsole was to simplify the creation of sessions (and this broke a lot of
code and you where not happy) but it seems that we do need to make some
compromise and align that.

Em qua, 10 de abr de 2019 às 16:27, Kurt Hindenburg <
noreply@phabricator.kde.org> escreveu:

hindenburg added a comment. View Revision
https://phabricator.kde.org/D14200

In D14200#447412 https://phabricator.kde.org/D14200#447412, @hindenburg
https://phabricator.kde.org/p/hindenburg/ wrote:

and it looks like $KONSOLE_DBUS_WINDOW is not set in 19.04.0

Well sometimes it is set and sometimes not

*REPOSITORY*
R319 Konsole

*REVISION DETAIL*
https://phabricator.kde.org/D14200

*To: *tcanabrava, Konsole, hindenburg
*Cc: *thsurrel, gennad, konsole-devel, ngraham, maximilianocuria,
hindenburg

Revision Contents
Changeset List

PathPackages
Msrc/ViewManager.cpp (45 lines)

Diff 55823

View Options

src/ViewManager.cpp

Loading...