| davidedmundson |
| KWin |
So far KWin didn't send axis_source, axis_discrete, and axis_stop. Even
though most of those events are optional, clients need them to work as
expected. For example, one needs axis_source and axis_stop to implement
kinetic scrolling; Xwayland needs axis_discrete to prevent multiple
scroll events when the compositor sends axis deltas greater than 10, etc.
BUG: 404152
FIXED-IN: 5.16.0
| Lint Errors | Excuse: cppcheck can't find definition of Q_DECLARE_METATYPE macro |
| Severity | Location | Code | Message |
|---|---|---|---|
| Error | libinput/device.h:579 | Cppcheck | unknownMacro |
| No Unit Test Coverage |
| Buildable 10657 | |
| Build 10675: arc lint + arc unit |
| kwinnamespace.h | ||
|---|---|---|
| 21 | utils.h is the general dumping ground for a random global enum in the kwin namespace | |
| kwinnamespace.h | ||
|---|---|---|
| 21 | Okay, I'll figure out how to put the enum there. The problem is that some X header file has defined None macro, which results in compilation error (QuickTileFlag enum has None enumerator). | |
| kwinnamespace.h | ||
|---|---|---|
| 21 | So, the rationale behind moving PointerAxisSource into a header was to avoid including "input.h" in platform.h and input_event.h. I guess I could reorder includes, but meh, it gets messy quite fast. Alternatively, I could still put PointerAxisSource in InputRedirection class.... | |
Alternatively, I could still put PointerAxisSource in InputRedirection class....
It's where "PointerAxis" is, they seem related. Works for me.
Seems a shame for this to get blocked over a tiny comment over about where an enum should be.
Seems a shame for this to get blocked over a tiny comment over about where an enum should be.
Well, the main blocker is the kwayland part. :-)
Move PointerAxisSource enum to InputRedirection class.
Some parts of code don't look good visually.