Add "notifications" and "notifications-disabled" icons
ClosedPublic

Authored by GB_2 on Apr 3 2019, 12:17 PM.

Details

Summary

BUG: 406121
Needed for the upcoming do not disturb mode and overhauled notifcations.


Test Plan

Search for "notifications" in Cuttlefish.

Diff Detail

Repository
R266 Breeze Icons
Branch
add-notifications-and-notifications-disabled-icons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10398
Build 10416: arc lint + arc unit
GB_2 created this revision.Apr 3 2019, 12:17 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 3 2019, 12:17 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Apr 3 2019, 12:17 PM
ngraham added a subscriber: ngraham.Apr 3 2019, 1:56 PM

+1 in general. However the fact that this black version doesn't match the outline/dimensions of the colored version (preferences-desktop-notification-bell) is triggering my OCD. :) Do you think you could match the dimensions of that icon?

GB_2 added a comment.EditedApr 3 2019, 1:59 PM

+1 in general. However the fact that this black version doesn't match the outline/dimensions of the colored version (preferences-desktop-notification-bell) is triggering my OCD. :) Do you think you could match the dimensions of that icon?

Is that even allowed/possible with this 16x16 resolution?
The padding rules of this resolution don't allow it to be higher.

abetts added a subscriber: abetts.Apr 3 2019, 2:03 PM

The line that goes across almost completely removes the bell's pendulum to the right. Maybe move the pendulum closer to the center so that even when there is that red strike line, the user can still make out that it is a notification bell

GB_2 updated this revision to Diff 55347.Apr 3 2019, 2:30 PM

Move bell's pendulum

GB_2 edited the summary of this revision. (Show Details)Apr 3 2019, 2:34 PM
abetts added a comment.Apr 3 2019, 2:35 PM
In D20226#442854, @GB_2 wrote:

Move bell's pendulum

Love it!

In D20226#442844, @GB_2 wrote:

+1 in general. However the fact that this black version doesn't match the outline/dimensions of the colored version (preferences-desktop-notification-bell) is triggering my OCD. :) Do you think you could match the dimensions of that icon?

Is that even allowed/possible with this 16x16 resolution?
The padding rules of this resolution don't allow it to be higher.

Hmm, well the big issue I see is that the bottom of the colored version flares out much more than the bottom of this one does:

If that's possible to change within the 16x16 margins, I'll accept it.

Also, could we create a 22x22 version too?

ndavis added a subscriber: ndavis.EditedApr 3 2019, 3:27 PM

The proportions aren't quite right.

This is one way to make a perfectly smooth bell. Subtract the red shapes from the black shapes.

the result is this:

GB_2 added a comment.Apr 3 2019, 3:31 PM

Also, could we create a 22x22 version too?

How can you efficiently do that without having to realign everything to the new grid manually?

ndavis added a comment.Apr 3 2019, 3:34 PM
In D20226#442906, @GB_2 wrote:

Also, could we create a 22x22 version too?

How can you efficiently do that without having to realign everything to the new grid manually?

You'll have to create it from scratch again, using the same method you used to create the 16px version. If you use the method that I just showed you, it'll be much easier than drawing it, but you still need to figure out how to get proportions that look right.

bruns added a subscriber: bruns.Apr 3 2019, 3:59 PM

The proportions aren't quite right.

This is one way to make a perfectly smooth bell. Subtract the red shapes from the black shapes.

the result is this:

Diagonal or round shapes are not required to be pixel grid aligned. Actually, it is not even possible, as there is always some antialiasing. It even helps to make round shapes a little bit bit larger than the pixel grid, so some of the corner/edge pixels are solid color.

ndavis added a comment.Apr 3 2019, 4:04 PM

Diagonal or round shapes are not required to be pixel grid aligned. Actually, it is not even possible, as there is always some antialiasing. It even helps to make round shapes a little bit bit larger than the pixel grid, so some of the corner/edge pixels are solid color.

I'm aware, but that's not the problem. If you look at the left side of the bell and the right side, the right side is wider. Maybe it's not that visible at 100%/96 DPI, but we should try to have resizable and reusable shapes when possible.

GB_2 updated this revision to Diff 55420.Apr 4 2019, 3:28 PM

Remake icons

GB_2 edited the summary of this revision. (Show Details)Apr 4 2019, 3:28 PM
ngraham accepted this revision.Apr 4 2019, 4:08 PM

Much nicer! This is a winner IMO.

This revision is now accepted and ready to land.Apr 4 2019, 4:08 PM
ndavis accepted this revision.Apr 5 2019, 2:02 AM

Those curves are perfect 👌

This revision was automatically updated to reflect the committed changes.