Dolphin: reintroduce information panel without Baloo
Needs ReviewPublic

Authored by i.Dark_Templar on Mar 30 2019, 6:03 PM.

Details

Reviewers
elvisangelaccio
broulik
ngraham
Group Reviewers
Dolphin
Summary

This panel is unconfigurable and contains only preview

Test Plan

Build dolphin with cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON .. and
make sure information panel is available and shows preview.

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
i.Dark_Templar created this revision.Mar 30 2019, 6:03 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 30 2019, 6:03 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
i.Dark_Templar requested review of this revision.Mar 30 2019, 6:03 PM

Without panel:

With panel:

ngraham edited reviewers, added: Dolphin; removed: rkflx.Mar 30 2019, 6:33 PM

To be honest I'm not sure I see the point. If the only things it shows are the filename and preview, then you can get that information by turning on inline previews and not need this.

To me dolphin without panel on right side looks unusual and unfamiliar. Due to that I made patch returning it.

And that panel may be resized, having preview of bigger size than previews of files in the central area. Of course, central area can have files resized too to increase preview, but then the screen would be able to hold much lesser amount of files.

And like before, this panel may be hidden to not take screen space if it's desired.