Differential D19983

Fix unhandled exception from DataStream::operator<<
ClosedPublic
Actions

Authored by fazevedo on Mar 22 2019, 9:47 PM.

Details

Reviewers
dvratil
dfaure
Commits
R165:06f1a32b5a5a: Fix unhandled exception from DataStream::operator<<
R165:0220e5052237: Fix unhandled exception from DataStream::operator<<
Summary

Depends on D19982

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fazevedo created this revision.Mar 22 2019, 9:47 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 22 2019, 9:47 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
fazevedo requested review of this revision.Mar 22 2019, 9:47 PM
dvratil accepted this revision.Mar 23 2019, 3:44 PM
This revision is now accepted and ready to land.Mar 23 2019, 3:44 PM
dvratil added a comment.Mar 25 2019, 9:37 AM

I think you can push this without the other patch, it does not really depend on it. Would be good to get this into 19.04 release.

fazevedo updated this revision to Diff 54761.Mar 25 2019, 11:22 AM

Dropped reference to previous patch

cfeck added a subscriber: cfeck.Mar 25 2019, 11:26 AM

Bug 401692?

Closed by commit R165:06f1a32b5a5a: Fix unhandled exception from DataStream::operator<< (authored by fazevedo). · Explain WhyMar 25 2019, 11:32 AM
This revision was automatically updated to reflect the committed changes.
fazevedo added a comment.Mar 25 2019, 11:34 AM
In D19983#437962, @cfeck wrote:

Bug 401692?

No idea, i did not checked a bug was open while fixing it, and reading the bug comments does not give hint of its origin.

dfaure added a comment.Mar 25 2019, 5:51 PM

Yes, I also tend to think this should fix bug 401692.

Revision Contents
Changeset List

PathPackages
Msrc/core/connection.cpp (2 lines)

Diff 54764

View Options

src/core/connection.cpp

Loading...