compile without foreach
Details
Details
Diff Detail
Diff Detail
- Repository
- R307 KPeople
- Branch
- compile_without_foreach (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10093 Build 10111: arc lint + arc unit
src/matchessolver.cpp | ||
---|---|---|
61–66 | iterators, please |
src/matchessolver.cpp | ||
---|---|---|
63 | You are calling destinationResolver.keys(urlB) twice here. |
src/matchessolver.cpp | ||
---|---|---|
62–66 | lst used to be called keys, there's no particular reason to rename it. | |
src/metacontact.cpp | ||
51 | (the qAsConst isn't technically needed since this method is const; but it doesn't hurt either) | |
src/widgets/plugins/mergecontactswidget.cpp | ||
185 | const & would be even better. (It'll get lengthy, so this might be a reason to switch for const auto & here, although some might object that the type isn't visible in the code here) |