Differential D19907

Add Theme::blurBehindEnabled()
ClosedPublic
Actions

Authored by kossebau on Mar 20 2019, 10:12 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R242:fb1a332948e3: Add Theme::blurBehindEnabled()

Summary

Allows themes to disable the blurring of what is behind panels,
if they either do not need it (being fully opaque) or by design want
non-blurry transparency.

Diff Detail

Repository

R242 Plasma Framework (Library)

Branch

addblurbehindflag

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9903
Build 9921: arc lint + arc unit

kossebau created this revision.Mar 20 2019, 10:12 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 20 2019, 10:12 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Mar 20 2019, 10:12 AM

Harbormaster completed remote builds in B9893: Diff 54399.Mar 20 2019, 10:12 AM

kossebau mentioned this in D19909: Enable blurbehind for panels only if theme sets it.Mar 20 2019, 10:14 AM

davidedmundson accepted this revision.Mar 20 2019, 11:42 AM

This revision is now accepted and ready to land.Mar 20 2019, 11:42 AM

kossebau added inline comments.Mar 20 2019, 12:06 PM

src/plasma/theme.h
391	And this and above should have been updated to "[BlurBehindEffect]", as actually used in the code. So much for quick pre-lunch uploading, tss. Will fix when landing the patch later tonight.

add missed-out application of the flag in PlasmaQuick::Dialog

Harbormaster completed remote builds in B9902: Diff 54416.Mar 20 2019, 3:28 PM

Remove sneaked-in code clean-up for repeated fetching of mask

@davidedmundson Is the new dialog code fine?

Harbormaster completed remote builds in B9903: Diff 54417.Mar 20 2019, 3:34 PM

davidedmundson accepted this revision.Mar 21 2019, 6:03 PM

Closed by commit R242:fb1a332948e3: Add Theme::blurBehindEnabled() (authored by kossebau). · Explain WhyMar 21 2019, 6:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/plasma/private/theme_p.h (2 lines)
M			src/plasma/private/theme_p.cpp (13 lines)
M			src/plasma/theme.h (16 lines)
M			src/plasma/theme.cpp (5 lines)
M			src/plasmaquick/dialog.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	54399	0ffe183		Mar 20 2019, 10:12 AM	★	★
Diff 2	54416	0ffe183	add missed-out application of the flag in PlasmaQuick::Dialog	Mar 20 2019, 3:28 PM	★	★
Diff 3	54417	0ffe183	Remove sneaked-in code clean-up for repeated fetching of mask	Mar 20 2019, 3:34 PM	★	★
Diff 4	54501	349648c	R242:fb1a332948e3ec7e40a7197c11456c968b0c0414	Mar 21 2019, 6:33 PM	★	★