Details
Diff Detail
- Repository
- R122 Powerdevil
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9807 Build 9825: arc lint + arc unit
I'm not sold on the use of pronouns here, we could actually do without them
If we agree to keep the pronouns, I'm not going to object but... we can sound both non-technical and professional at the same time :D
P.S. I could use input on "All planned sleep", it's less technical but it's plain weird :D
Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours?
Don't have a better idea for planned sleep, maybe just planned sleep actions?
Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours?
Haha yeah.
Granted, even these pronouns are waaaay better than the prompt saying "I am going to sleep."
Outright creepy :D
Mostly good, just a new nitpicks and suggestions:
daemon/powerdevilcore.cpp | ||
---|---|---|
256 | I'd say "using activity <whatever>" | |
330 | Remove "the profile" | |
367 | "or the action is not supported" -> "or the action not being supported" | |
541–542 | Are we 100% sure that name will always be a good enough string that the user will recognize it as their mouse? (not a rhetorical question, I really am wondering :) ) Same for other instances below too. | |
607 | "go into" -> "enter" ? | |
612 | "go to sleep" is just fine here | |
643 | Not sure this comment is really necessary :) |
daemon/powerdevilcore.cpp | ||
---|---|---|
330 | Hmm sure | |
367 | "or because the action is not supported", "This is due to the action not being supported" sounds too elaborate for my taste and I'd rather have a disconnected clause here | |
541–542 | I thought about that, then realized that the heading says "Mouse" (Mouse Battery Low) "Keyboard" etc. so it seems redundant too (to repeat it in the body text) | |
607 | Better, yes. We could use just "enter hibernation" without mode too | |
612 | Not very fancy tho 🤣 | |
643 | :) |
daemon/powerdevilcore.cpp | ||
---|---|---|
330 | Actually you're right, without "the profile" and "it" it sounds fancier haha |
daemon/powerdevilcore.cpp | ||
---|---|---|
541–542 | Since you removed the separation between the three cases you might as well unify the codebase into one. Now you have three separate identical strings. Also, "The battery in (some device) is running low" with the parenthesis is a bit awkward since now it's the sentence's subject. | |
580 | not a fan of that hyphen. It is in the heading, so just change the main text to "To continue using your computer..." | |
641 | Sounds like from now on it will never suspend anymore. |