[kfilemetadata] Make it compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Mar 10 2019, 1:26 PM.

Details

Reviewers

dfaure
bruns

Group Reviewers

Baloo

Commits

Summary

compile without foreach

Test Plan

autotest ok

Repository

R286 KFileMetaData

Branch

compile_without_foreach (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9771
Build 9789: arc lint + arc unit

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Mar 10 2019, 1:26 PM

bruns added inline comments.

src/externalextractor.cpp
150	Can you change this to iterate over the entries, without intermediate list?
src/externalwriter.cpp
110–111	dito, iteration without intermediate list.
src/extractors/taglibextractor.cpp
928 ↗	(On Diff #53597)	The changes in taglibextractor are no longer necessary after D18826 has landed, you can omit these.

src/extractors/taglibextractor.cpp
928 ↗	(On Diff #53597)	Ah ? so all was not commited when you wrote that it"s ok to regenerate patch ?

bruns requested changes to this revision.Mar 17 2019, 8:42 PM

This revision now requires changes to proceed.Mar 17 2019, 8:42 PM

Fix code as requested

This revision is now accepted and ready to land.Mar 18 2019, 6:23 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/externalextractor.cpp (18 lines)
M			src/externalwriter.cpp (14 lines)
M			src/extractorplugin.cpp (2 lines)
M			src/extractors/office2007extractor.cpp (2 lines)
M			src/writercollection.cpp (11 lines)
M			tests/dump.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53597	2585edd		Mar 10 2019, 1:26 PM	★	★
Diff 2	54174	4c5c4f5	Fix code as requested	Mar 18 2019, 6:20 AM	★	★
Diff 3	54175	4c5c4f5	R286:31f4a5c075851bf2c5ced819603e71d4c3934b74	Mar 18 2019, 7:56 AM	★	★