[fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout
ClosedPublic

Authored by filipf on Mar 14 2019, 5:45 AM.

Details

Summary

This patch ports fuzzy-clock's configuration window to QQC2 and Kirigami.FormLayout

Test Plan

Before:

After:

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Mar 14 2019, 5:45 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 14 2019, 5:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mar 14 2019, 5:45 AM
filipf edited the summary of this revision. (Show Details)Mar 14 2019, 5:47 AM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, VDG, ngraham.
filipf planned changes to this revision.Mar 14 2019, 5:49 AM

Unforunately I'm getting bad stepSize behavior with the QQC2.Slider. It's reproducible even when keeping the original code and only porting the slider to QQC2 (that entails "from", "to", and removing "tickmarks"). If we can't get it to work we probably still need to document the issue better.

Unless I'm doing something wrong, QQC2 Slider seems broken when minimumValue aka from is 1:

import QtQuick.Controls 2.5
Slider {
from: 1
to: 5
stepSize: 1
}

We'll need a bug report on this slider issue if we're gonna work around it, at a minimum.

filipf updated this revision to Diff 53893.Mar 14 2019, 4:07 PM

link the bug report for qqc2 slider

We'll need a bug report on this slider issue if we're gonna work around it, at a minimum.

Done: https://bugs.kde.org/show_bug.cgi?id=405471

ngraham accepted this revision.Mar 14 2019, 5:40 PM

Thanks. I can confirm the bug not only here but in the wild in our libinput mouse and touchpad KCMs. The workaround seems sane for now.

This revision is now accepted and ready to land.Mar 14 2019, 5:40 PM
This revision was automatically updated to reflect the committed changes.