Port to ECM's component/imported target based FindXCB
ClosedPublic

Authored by vkrause on Mar 2 2019, 11:01 AM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Mar 2 2019, 11:01 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2019, 11:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
vkrause requested review of this revision.Mar 2 2019, 11:01 AM
apol accepted this revision.Mar 4 2019, 1:56 AM
This revision is now accepted and ready to land.Mar 4 2019, 1:56 AM
This revision was automatically updated to reflect the committed changes.
rikmills added a subscriber: rikmills.EditedMar 9 2019, 9:20 AM

Results in cmake configure build failure on Neon

https://build.neon.kde.org/job/bionic_unstable_kde_plasma-desktop_bin_amd64/292/consoleFull

EDIT: My bad. Change now requires libxcb-util-dev is installed as a build dep. Not very clear from the error.