[wayland] Implement size and position window rules
ClosedPublic

Authored by zzag on Feb 28 2019, 12:21 PM.

Details

Summary

CCBUG: 409797

Test Plan

The new tests pass.

Diff Detail

Repository
R108 KWin
Lint
Lint ErrorsExcuse: foobar
SeverityLocationCodeMessage
Errorautotests/integration/shell_client_rules_test.cpp:390CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:391CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:467CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:468CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:525CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:526CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:662CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:663CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1332CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1333CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1385CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1386CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1442CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1443CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1560CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1561CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1643CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1644CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1689CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1690CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1737CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1738CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1831CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1832CppcheckdoubleFree
Errorautotests/integration/shell_client_rules_test.cpp:1911CppcheckdoubleFree
Unit
No Unit Test Coverage
Build Status
Buildable 8980
Build 8998: arc lint + arc unit
zzag created this revision.Feb 28 2019, 12:21 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 28 2019, 12:21 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 28 2019, 12:21 PM
zzag updated this revision to Diff 52817.Feb 28 2019, 12:51 PM

More QEXPECT_FAIL

zzag updated this revision to Diff 52840.Feb 28 2019, 4:26 PM

use enums in the tests

zzag updated this revision to Diff 52842.Feb 28 2019, 4:27 PM

use enums in the tests

zzag updated this revision to Diff 61437.Jul 9 2019, 5:58 PM

Adjust to recent ShellClient changes.

zzag updated this revision to Diff 61442.Jul 9 2019, 6:36 PM

Better wording in a comment.

ngraham edited the summary of this revision. (Show Details)Jul 15 2019, 2:32 AM
zzag added a comment.Jul 28 2019, 10:26 AM

If there are no objections, I'm gonna land this patch in a couple days.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 29 2019, 6:21 PM
This revision was automatically updated to reflect the committed changes.