[sddm-theme/lock screen] Add shadows to action buttons
AbandonedPublic

Authored by rooty on Feb 26 2019, 6:10 PM.

Details

Reviewers
ngraham
filipf
Group Reviewers
VDG
Test Plan

Action buttons - before:


after:

(The blur's been removed in in the screenshots in anticipation of the patch that will make the removal of the blur effect official.)

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D19364
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8901
Build 8919: arc lint + arc unit
rooty created this revision.Feb 26 2019, 6:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2019, 6:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Feb 26 2019, 6:10 PM
rooty updated this revision to Diff 52654.Feb 26 2019, 6:11 PM

Remove extra line

rooty edited the test plan for this revision. (Show Details)Feb 26 2019, 6:13 PM
rooty added reviewers: VDG, ngraham, filipf.

P.S. I haven't yet resolved this error:

[19:14:33.680] (WW) GREETER: file:///home/rooty/kde/temp/sddm-theme/components/ActionButton.qml:30: ReferenceError: GraphicsInfo is not defined

rooty updated this revision to Diff 52655.Feb 26 2019, 6:16 PM

Resolve "GraphicsInfo is not defined" error by bumping up QtQuick version

rooty retitled this revision from [sddm-theme/lock screen] WIP, Add shadows to action buttons and redo username/prompt message shadow to [sddm-theme/lock screen] Add shadows to action buttons and redo username/prompt message shadow.Feb 26 2019, 6:19 PM
rooty retitled this revision from [sddm-theme/lock screen] Add shadows to action buttons and redo username/prompt message shadow to [sddm-theme/lock screen] Add shadows to action buttons.Feb 26 2019, 8:00 PM
rooty edited the test plan for this revision. (Show Details)
rooty updated this revision to Diff 52667.Feb 26 2019, 8:02 PM

Remove UserDelegate changes, rebase

rooty updated this revision to Diff 52668.Feb 26 2019, 8:05 PM

Let's try this again

rooty updated this revision to Diff 52673.Feb 26 2019, 8:17 PM

Resolve conflicts

rooty updated this revision to Diff 52677.Feb 26 2019, 8:35 PM

Maybe this'll work

rooty updated this revision to Diff 52678.Feb 26 2019, 8:36 PM

Remove hardcoded Noto Sans blunder

filipf accepted this revision as: filipf.Feb 26 2019, 11:34 PM

Will let Nate verify that the outline patch has been done well here, but otherwise looks good.

This revision is now accepted and ready to land.Feb 26 2019, 11:34 PM
rooty added a comment.Feb 27 2019, 9:34 AM

Will let Nate verify that the outline patch has been done well here, but otherwise looks good.

Wait but I haven't added outlines, just shadows... Should I add outlines for software rendering too?

ngraham requested changes to this revision.Feb 27 2019, 2:32 PM

Yep, needs an outline instead of a shadow when using software rendering, just like the other text with shadows.

Another thing is that in my previous attempt at this, I made the shadows optional, since there are places where ActionButtons are used that don't require any additional contrast for the text, such as on the logout screen. So it's best to omit them there. You can see how I did that in D16031, and it might be nice to do it here, too.

This revision now requires changes to proceed.Feb 27 2019, 2:32 PM
rooty added a comment.Feb 27 2019, 7:10 PM

Yep, needs an outline instead of a shadow when using software rendering, just like the other text with shadows.

I'll add an outline sure

Another thing is that in my previous attempt at this, I made the shadows optional, since there are places where ActionButtons are used that don't require any additional contrast for the text, such as on the logout screen. So it's best to omit them there. You can see how I did that in D16031, and it might be nice to do it here, too.

Isn't that true of UserDelegate too though?

We could separate the files, use separate versions for the login screen and the lock screen. That's why I haven't pushed the clock/userdelegate patch yet

Yep, needs an outline instead of a shadow when using software rendering, just like the other text with shadows.

I'll add an outline sure

Another thing is that in my previous attempt at this, I made the shadows optional, since there are places where ActionButtons are used that don't require any additional contrast for the text, such as on the logout screen. So it's best to omit them there. You can see how I did that in D16031, and it might be nice to do it here, too.

Isn't that true of UserDelegate too though?

We could separate the files, use separate versions for the login screen and the lock screen. That's why I haven't pushed the clock/userdelegate patch yet

That's true, yeah. No need to create separate files, just add a public property in actionButton that's connected to the shadow/outline visibility.

property alias labelShadow: labelShadow.visible

And then on the login screen itself, you would set labelShadow: true for each ActionButton added there, and in the logout screen, you would set labelShadow: isLightColor ? false : true

mglb added a subscriber: mglb.Mar 1 2019, 11:11 AM

What about adding the same shadow under icons? Otherwise it looks like a text floating above flat background.

rooty added a comment.Mar 1 2019, 11:40 AM
In D19364#422438, @mglb wrote:

What about adding the same shadow under icons? Otherwise it looks like a text floating above flat background.

We're actually deliberating on whether to abandon the shadow idea altogether in D19433 and D19409

rooty abandoned this revision.Mar 2 2019, 4:40 AM