update default server to kde one to download data
AbandonedPublic

Authored by jjazeix on Feb 22 2019, 6:09 PM.

Details

Reviewers
None
Group Reviewers
GCompris: Improvements
Summary

Update from gcompris.net to cdn.kde.org

Test Plan

Check in the logs if it looked in the new address.
Check in the ~/.config/gcompris/gcompris-qt.conf if the new server is set instead of the previous one.
Only set the default server to kde one if the previous one was gcompris.net, we don't want to force if there is an internal or custom server

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
jjazeix created this revision.Feb 22 2019, 6:09 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 22 2019, 6:09 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
jjazeix requested review of this revision.Feb 22 2019, 6:09 PM
jjazeix updated this revision to Diff 52327.Feb 22 2019, 6:13 PM
jjazeix edited the test plan for this revision. (Show Details)
apol added a subscriber: apol.Feb 22 2019, 7:08 PM
apol added inline comments.
src/core/ApplicationSettings.cpp
157

these are char* so == doesn't work.

Make them (or at least either) a QLatin1String, otherwise you'll be comparing pointers.

jjazeix added inline comments.Feb 22 2019, 7:37 PM
src/core/ApplicationSettings.cpp
157

m_downloadServerUrl is a QString and there is a operator==(const char *) (https://doc.qt.io/qt-5/qstring.html#operator-eq-eq-1) so it is fine?