[kcmkwin] Add requestConfigure to effects model
ClosedPublic

Authored by zzag on Feb 3 2019, 5:03 PM.

Details

Summary

The main motivation for adding this method is to avoid code duplication.
Both virtual desktops kcm and desktop effects kcm have their own logic
to create configuration dialogs for effects.

On the bright side, if we add support for declarative effect kcms, we
will need to change only this method.

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8669
Build 8687: arc lint + arc unit
zzag created this revision.Feb 3 2019, 5:03 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 3 2019, 5:03 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 3 2019, 5:03 PM
zzag updated this revision to Diff 50802.Feb 3 2019, 8:16 PM

update

zzag updated this revision to Diff 50887.Feb 4 2019, 9:14 PM

Rebase.

davidedmundson accepted this revision.Feb 20 2019, 10:52 AM
This revision is now accepted and ready to land.Feb 20 2019, 10:52 AM
zzag updated this revision to Diff 52228.Feb 21 2019, 6:07 PM

Rebase on top of 18703

zzag updated this revision to Diff 52272.Feb 22 2019, 9:28 AM

rebase on 703

This revision was automatically updated to reflect the committed changes.