Change shadow color to 0,0,0
ClosedPublic

Authored by ndavis on Feb 18 2019, 6:34 PM.

Details

Summary

The current shadow color is Shade Black, which is also used as the ViewBackground color in Breeze dark. This makes the shadow invisible when 2 windows without borders overlap with touching View areas. It also makes color banding worse on cheap displays. Changing the color to black makes the shadow visible on most backgrounds and slightly improves the look of the shadow on cheap displays.

Test Plan

Before:


After:

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Feb 18 2019, 6:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2019, 6:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Feb 18 2019, 6:34 PM
ndavis edited the test plan for this revision. (Show Details)Feb 18 2019, 6:41 PM
ngraham accepted this revision.Feb 18 2019, 6:42 PM
ngraham added a subscriber: ngraham.

I changed this from black to Shade Black as a compromise to get https://cgit.kde.org/breeze.git/commit/?id=9fb5d3abb18cde0ef63102cb06f1a936152ccaef done and I think we have to consider the experiment a failure. It results in various visual regressions and black is a better default.

+1

This revision is now accepted and ready to land.Feb 18 2019, 6:42 PM
ndavis edited the test plan for this revision. (Show Details)Feb 18 2019, 6:44 PM
filipf accepted this revision.Feb 18 2019, 6:46 PM
filipf added a subscriber: filipf.

Another big +1 for all the reasons already mentioned.

This revision was automatically updated to reflect the committed changes.
zzag added a subscriber: zzag.Feb 18 2019, 6:59 PM

What about kstyle?

Ah yes, gotta make the same change in kstyle/breeze.kcfg too. @ndavis can you do that?