Make look of Font Management KCM UI more consistent
ClosedPublic

Authored by GB_2 on Feb 16 2019, 1:02 PM.

Details

Summary

Apply the KDE HIG and make tooltips, buttons and others more consistent and better looking.

Test Plan

Open the Font Management KCM.

Diff Detail

Repository
R119 Plasma Desktop
Branch
make-look-of-font-management-kcm-ui-more-consistent (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8415
Build 8433: arc lint + arc unit
GB_2 created this revision.Feb 16 2019, 1:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 16 2019, 1:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 16 2019, 1:02 PM
GB_2 retitled this revision from Make look of Fonts KCM UI more consistent to Make look of Font Management KCM UI more consistent.Feb 16 2019, 1:55 PM
ngraham requested changes to this revision.Feb 16 2019, 2:46 PM
ngraham added a subscriber: ngraham.
ngraham added inline comments.
kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
236

This one doesn't need an ellipsis. If the window/dialog that pops up when you click on it is nothing more than a confirmation box, we don't use ellipsis.

However the confirmation dialog that results from clicking on this could use better icons in its buttons for sure.

240

Same: no ellipsis when the "additional user input required" is just a confirmation dialog (and do we even need this confirmation dialog anyway???).

244

Same

295

Same

This revision now requires changes to proceed.Feb 16 2019, 2:46 PM
GB_2 added inline comments.Feb 16 2019, 2:53 PM
kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
236

The HIG says "Indicate a command that needs additional information (including confirmation) by adding an ellipsis at the end of the button label."

ngraham added inline comments.Feb 16 2019, 2:56 PM
kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
236

Heh I think that may be a typo and the word was supposed to be "excluding". I specifically remember having a conversation about this and we concluded that confirmation prompts didn't count because then you would need to conditionally give ellipses to Close and a whole bunch of other things that don't really need it.

GB_2 added inline comments.Feb 16 2019, 2:57 PM
kcms/kfontinst/kcmfontinst/KCmFontInst.cpp
236

Ok, will change it.
Then we also need to update the HIG.

GB_2 updated this revision to Diff 51866.Feb 16 2019, 3:03 PM

Remove unneeded ellipses

GB_2 marked 7 inline comments as done.Feb 16 2019, 3:05 PM

While we're at it, can we turn those Yes/No messageboxes into <perform action>/Cancel style instead?

GB_2 added a comment.Feb 16 2019, 3:23 PM

While we're at it, can we turn those Yes/No messageboxes into <perform action>/Cancel style instead?

Sure

GB_2 updated this revision to Diff 51877.EditedFeb 16 2019, 4:37 PM

Use <perform action>/Cancel style message box buttons.

ngraham accepted this revision.Feb 16 2019, 11:07 PM

Much better, thanks!

This revision is now accepted and ready to land.Feb 16 2019, 11:07 PM
This revision was automatically updated to reflect the committed changes.