Apply the KDE HIG and make tooltips, buttons and others more consistent and better looking.
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
- Commits
- R119:8596ae908533: Make look of Font Management KCM UI more consistent
Open the Font Management KCM.
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- make-look-of-font-management-kcm-ui-more-consistent (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8415 Build 8433: arc lint + arc unit
kcms/kfontinst/kcmfontinst/KCmFontInst.cpp | ||
---|---|---|
236 | This one doesn't need an ellipsis. If the window/dialog that pops up when you click on it is nothing more than a confirmation box, we don't use ellipsis. However the confirmation dialog that results from clicking on this could use better icons in its buttons for sure. | |
240 | Same: no ellipsis when the "additional user input required" is just a confirmation dialog (and do we even need this confirmation dialog anyway???). | |
244 | Same | |
295 | Same |
kcms/kfontinst/kcmfontinst/KCmFontInst.cpp | ||
---|---|---|
236 | The HIG says "Indicate a command that needs additional information (including confirmation) by adding an ellipsis at the end of the button label." |
kcms/kfontinst/kcmfontinst/KCmFontInst.cpp | ||
---|---|---|
236 | Heh I think that may be a typo and the word was supposed to be "excluding". I specifically remember having a conversation about this and we concluded that confirmation prompts didn't count because then you would need to conditionally give ellipses to Close and a whole bunch of other things that don't really need it. |
kcms/kfontinst/kcmfontinst/KCmFontInst.cpp | ||
---|---|---|
236 | Ok, will change it. |
While we're at it, can we turn those Yes/No messageboxes into <perform action>/Cancel style instead?