One thing we could do is not pass the string directly to toString and check if there's any ' character (there should be at least/exactly 2) if not ignore the translation and go with untranslated, that will be better than "random stuff", but i guess this is probably enough.

@ltoscano what do you think?

If it's not too difficult to pre-filter the string, maybe it's worth doing.

Can you add a qWarning in the else branches saying something "the translation is wrong, file a bug report"?

I didn't realize you moved the text out of the i18n call.

If you do that gettext won't extract it and thus it'll be untranslatable.

I see that you did that so you can reuse it untranslated later.

Maybe this would work (haven't tried it)?

KLocalizedString s = ki18nc(context, text);
const QString translatedFormat = s.toString();
if (translatedFormat.count(QLatin1Char('\'')) == 2) { /* good */ }
else { qCWarning();      newGroupValue = s.toString({"en"}); }

i think that would mean "no" translation in the else since it is asking for an en translation.

In D18769#413805, @aacid wrote:

I didn't realize you moved the text out of the i18n call.

If you do that gettext won't extract it and thus it'll be untranslatable.

I see that you did that so you can reuse it untranslated later.

Maybe this would work (haven't tried it)?

KLocalizedString s = ki18nc(context, text);
const QString translatedFormat = s.toString();
if (translatedFormat.count(QLatin1Char('\'')) == 2) { /* good */ }
else { qCWarning();      newGroupValue = s.toString({"en"}); }

i think that would mean "no" translation in the else since it is asking for an en translation.

Ah sorry, didn't know that. I'll try.

Code looks good to me, do you want me to actually test it or are you confident enough that it works?

@aacid If the french translation is still broken, maybe would be good to test this patch using a french locale?

Hmmmm, it doesn't seem to totally work

I get this https://i.imgur.com/bM3IPeu.png

I guess the MMMM and yyyy should have been replaced by actual text, right?

In D18769#415758, @aacid wrote:

Hmmmm, it doesn't seem to totally work

I get this https://i.imgur.com/bM3IPeu.png

I guess the MMMM and yyyy should have been replaced by actual text, right?

Yeah. Did you get the qWarning in the else branch? How do I reproduce that?

In D18769#418475, @elvisangelaccio wrote:

In D18769#415758, @aacid wrote:

Hmmmm, it doesn't seem to totally work

I get this https://i.imgur.com/bM3IPeu.png

I guess the MMMM and yyyy should have been replaced by actual text, right?

Yeah. Did you get the qWarning in the else branch? How do I reproduce that?

Well, you need to be running in a localized language and then break your translation.

Here is a broken .mo for dolphin (in french)

In D18769#420858, @aacid wrote:

Here is a broken .mo for dolphin (in french)

dolphin.mo42 KBDownload

install it to /usr/share/locale/fr/LC_MESSAGES/dolphin.mo and if you have the french locale running it with LANG=fr_FR.UTF-8 dolphin should give you the broken behaviour, if you don't have the fr locale setup just copy it to the italian folder :D

Thanks, I was able to reproduce it using this file. I forgot to call QDateTime::toString() also when we go with the untranslated string...