Prevent password from being visible
ClosedPublic

Authored by dkardarakos on Feb 16 2019, 9:34 AM.

Details

Summary

When the user enters the PIN of the SIM, the password is displayed in cleartext. This change masks visible characters with password characters.

Test Plan

Insert a SIM card and check the dialog that opens

Diff Detail

Repository
R20 Plasma Phone Components
Lint
Lint Skipped
Unit
Unit Tests Skipped
dkardarakos requested review of this revision.Feb 16 2019, 9:34 AM
dkardarakos created this revision.
apol accepted this revision.Feb 20 2019, 4:59 PM
apol added a subscriber: apol.

LGTM.
Maybe it would make sense to set passwordMaskDelay: Units.longDuration?

This revision is now accepted and ready to land.Feb 20 2019, 4:59 PM
bshah accepted this revision.Feb 20 2019, 5:02 PM
In D19076#416207, @apol wrote:

LGTM.
Maybe it would make sense to set passwordMaskDelay: Units.longDuration?

I had tried it but it worked only when leaving the text field editable and entering digits via the virtual keyboard...

This revision was automatically updated to reflect the committed changes.