Make it part of the base class to facilitate testing.
Details
Details
- Reviewers
aacid - Group Reviewers
KDE Games - Commits
- R410:17ec0c510f88: Add a test for solverFormat().
run "make test" and test base functionality.
Diff Detail
Diff Detail
- Repository
- R410 KPatience
- Branch
- add-tests
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8292 Build 8310: arc lint + arc unit
| dealer.cpp | ||
|---|---|---|
| 2106 ↗ | (On Diff #51253) | Typo: overrided -> overridden |
| dealer.cpp | ||
|---|---|---|
| 2107 ↗ | (On Diff #51273) | make it pure virtual? |
Comment Actions
@aacid : re making it pure virtual that would require every subclass to supply it and it isn't needed or used by many of the game variant subclasses.
Comment Actions
ah, right, it's a function you only call for golf.
Are you planning to extend this to other games? Otherwise you could just static_cast to Golf and call the function defined there without needing to add it to the base class.
Comment Actions
@aacid : well, there are similar solverFormat() methods in Freecell and in Simple Simon, but they all can be non-virtual and I guess a static_cast will work.