Move Look and Feel KCM to top level
ClosedPublic

Authored by GB_2 on Feb 10 2019, 7:07 AM.

Details

Summary

Moves the LnF KCM from the Workspace Theme category to the top level (to the Appearance section), because:

  • the KCM affects everything, not just workspace themes
  • then it's faster to discover the KCM and go to it

It won't affect any other KCMs, so this change should be fine.
Also see T8871.

Test Plan

Open the system settings.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Feb 10 2019, 7:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 10 2019, 7:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 10 2019, 7:07 AM
rooty accepted this revision.Feb 10 2019, 7:20 AM
rooty added a subscriber: rooty.

this seems like a simple enough change and we did agree to put it there, but maybe wait for someone else to okay it too before landing it

you got my vote though

This revision is now accepted and ready to land.Feb 10 2019, 7:20 AM
ngraham accepted this revision.Feb 10 2019, 2:46 PM
ngraham added reviewers: davidedmundson, abetts.
ngraham added subscribers: abetts, davidedmundson, ngraham.

I agree that this makes a lot of sense. However I want to make sure @davidedmundson and @abetts are okay with this since they've previously expressed reservations about moving KCMs around too early.

This revision now requires review to proceed.Feb 10 2019, 2:46 PM
This revision is now accepted and ready to land.Feb 13 2019, 8:14 PM
davidedmundson accepted this revision.Feb 13 2019, 8:34 PM
This revision was automatically updated to reflect the committed changes.