Differential D18822

Fix Windows build [hopefully]
ClosedPublic
Actions

Authored by aacid on Feb 7 2019, 6:45 PM.

Details

Reviewers
vonreth
Commits
R283:c0854de284b7: Fix Windows build [hopefully]

Diff Detail

Repository
R283 KAuth
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Feb 7 2019, 6:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 7 2019, 6:45 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Feb 7 2019, 6:45 PM
kossebau added a comment.Feb 7 2019, 8:57 PM

Looks fine to me from quick reading, everything done I would have thought of (whatever that is worth :P )
+1

vonreth requested changes to this revision.Feb 9 2019, 3:44 PM

Doesn't build yet, we really need pre commit ci....

Scanning dependencies of target KF5AuthCore_autogen
[  1%] Automatic MOC for target KF5AuthCore
[  1%] Built target KF5AuthCore_autogen
Scanning dependencies of target KF5AuthCore
[  3%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/kauthaction.cpp.obj
kauthaction.cpp
[  4%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/kauthactionreply.cpp.obj
kauthactionreply.cpp
[  6%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/kauthexecutejob.cpp.obj
kauthexecutejob.cpp
[  8%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/AuthBackend.cpp.obj
AuthBackend.cpp
[  9%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/BackendsManager.cpp.obj
BackendsManager.cpp
[ 11%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/HelperProxy.cpp.obj
HelperProxy.cpp
[ 13%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/kauthhelpersupport.cpp.obj
kauthhelpersupport.cpp
[ 14%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/kauthdebug.cpp.obj
kauthdebug.cpp
[ 16%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/backends/fake/FakeBackend.cpp.obj
FakeBackend.cpp
[ 18%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/backends/fakehelper/FakeHelperProxy.cpp.obj
FakeHelperProxy.cpp
[ 19%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/ECMQmLoader-kauth5_qt.cpp.obj
ECMQmLoader-kauth5_qt.cpp
[ 21%] Building CXX object src/CMakeFiles/KF5AuthCore.dir/KF5AuthCore_autogen/mocs_compilation.cpp.obj
mocs_compilation.cpp
[ 22%] Linking CXX shared library ..\bin\KF5AuthCore.dll
   Creating library ..\lib\KF5AuthCore.lib and object ..\lib\KF5AuthCore.exp
   Creating library ..\lib\KF5AuthCore.lib and object ..\lib\KF5AuthCore.exp
[ 22%] Built target KF5AuthCore
Scanning dependencies of target KF5Auth_autogen
[ 24%] Automatic MOC for target KF5Auth
[ 24%] Built target KF5Auth_autogen
Scanning dependencies of target KF5Auth
[ 26%] Building CXX object src/CMakeFiles/KF5Auth.dir/kauthdebug.cpp.obj
kauthdebug.cpp
[ 27%] Building CXX object src/CMakeFiles/KF5Auth.dir/kauthobjectdecorator.cpp.obj
kauthobjectdecorator.cpp
[ 29%] Building CXX object src/CMakeFiles/KF5Auth.dir/KF5Auth_autogen/mocs_compilation.cpp.obj
mocs_compilation.cpp
[ 31%] Linking CXX shared library ..\bin\KF5Auth.dll
   Creating library ..\lib\KF5Auth.lib and object ..\lib\KF5Auth.exp
   Creating library ..\lib\KF5Auth.lib and object ..\lib\KF5Auth.exp
[ 31%] Built target KF5Auth
Scanning dependencies of target kauth_helper_plugin_autogen
[ 32%] Automatic MOC for target kauth_helper_plugin
[ 32%] Built target kauth_helper_plugin_autogen
[ 34%] Generating kf5authadaptor.cpp, kf5authadaptor.h
[ 36%] Generating kf5authadaptor.moc
Scanning dependencies of target kauth_helper_plugin
[ 37%] Building CXX object src/CMakeFiles/kauth_helper_plugin.dir/backends/dbus/DBusHelperProxy.cpp.obj
DBusHelperProxy.cpp
[ 39%] Building CXX object src/CMakeFiles/kauth_helper_plugin.dir/kf5authadaptor.cpp.obj
kf5authadaptor.cpp
[ 40%] Building CXX object src/CMakeFiles/kauth_helper_plugin.dir/HelperProxy.cpp.obj
HelperProxy.cpp
[ 42%] Building CXX object src/CMakeFiles/kauth_helper_plugin.dir/kauthdebug.cpp.obj
kauthdebug.cpp
[ 44%] Building CXX object src/CMakeFiles/kauth_helper_plugin.dir/kauth_helper_plugin_autogen/mocs_compilation.cpp.obj
mocs_compilation.cpp
[ 45%] Linking CXX shared module ..\bin\kauth_helper_plugin.dll
   Creating library ..\lib\kauth_helper_plugin.lib and object ..\lib\kauth_helper_plugin.exp
   Creating library ..\lib\kauth_helper_plugin.lib and object ..\lib\kauth_helper_plugin.exp
[ 45%] Built target kauth_helper_plugin
Scanning dependencies of target kauth_tests_static_autogen
[ 47%] Automatic MOC for target kauth_tests_static
[ 47%] Built target kauth_tests_static_autogen
[ 49%] Generating kf5authadaptor.cpp, kf5authadaptor.h
[ 50%] Generating kf5authadaptor.moc
Scanning dependencies of target kauth_tests_static
[ 52%] Building CXX object autotests/CMakeFiles/kauth_tests_static.dir/__/src/kauthaction.cpp.obj
kauthaction.cpp
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(60): warning C4273: 'KAuth::Action::Action': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(112): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(65): warning C4273: 'KAuth::Action::Action': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(115): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(70): warning C4273: 'KAuth::Action::Action': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(121): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(77): warning C4273: 'KAuth::Action::Action': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(130): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(85): warning C4273: 'KAuth::Action::~Action': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(133): note: see previous definition of '{dtor}'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(90): warning C4273: 'KAuth::Action::operator =': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(136): note: see previous definition of '='
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(101): warning C4273: 'KAuth::Action::operator ==': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(149): note: see previous definition of '=='
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(106): warning C4273: 'KAuth::Action::operator !=': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(158): note: see previous definition of '!='
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(112): warning C4273: 'KAuth::Action::name': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(169): note: see previous definition of 'name'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(117): warning C4273: 'KAuth::Action::setName': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(179): note: see previous definition of 'setName'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(133): warning C4273: 'KAuth::Action::timeout': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(191): note: see previous definition of 'timeout'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(138): warning C4273: 'KAuth::Action::setTimeout': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(202): note: see previous definition of 'setTimeout'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(143): warning C4273: 'KAuth::Action::details': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(221): note: see previous definition of 'details'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(148): warning C4273: 'KAuth::Action::setDetails': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(211): note: see previous definition of 'setDetails'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(153): warning C4273: 'KAuth::Action::isValid': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(247): note: see previous definition of 'isValid'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(158): warning C4273: 'KAuth::Action::setArguments': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(305): note: see previous definition of 'setArguments'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(163): warning C4273: 'KAuth::Action::addArgument': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(329): note: see previous definition of 'addArgument'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(168): warning C4273: 'KAuth::Action::arguments': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(315): note: see previous definition of 'arguments'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(173): warning C4273: 'KAuth::Action::helperId': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(261): note: see previous definition of 'helperId'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(179): warning C4273: 'KAuth::Action::setHelperId': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(278): note: see previous definition of 'setHelperId'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(184): warning C4273: 'KAuth::Action::setParentWidget': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(369): note: see previous definition of 'setParentWidget'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(189): warning C4273: 'KAuth::Action::parentWidget': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(378): note: see previous definition of 'parentWidget'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(194): warning C4273: 'KAuth::Action::status': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(346): note: see previous definition of 'status'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(203): warning C4273: 'KAuth::Action::execute': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(353): note: see previous definition of 'execute'
C:\Craft\_\d6b2a56\kauth\src\kauthaction.cpp(208): warning C4273: 'KAuth::Action::hasHelper': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthaction.h(293): note: see previous definition of 'hasHelper'
[ 54%] Building CXX object autotests/CMakeFiles/kauth_tests_static.dir/__/src/kauthactionreply.cpp.obj
kauthactionreply.cpp
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(48): warning C4273: 'KAuth::ActionReply::SuccessReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(355): note: see previous definition of 'SuccessReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(52): warning C4273: 'KAuth::ActionReply::HelperErrorReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(356): note: see previous definition of 'HelperErrorReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(58): warning C4273: 'KAuth::ActionReply::HelperErrorReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(357): note: see previous definition of 'HelperErrorReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(64): warning C4273: 'KAuth::ActionReply::NoResponderReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(359): note: see previous definition of 'NoResponderReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(68): warning C4273: 'KAuth::ActionReply::NoSuchActionReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(360): note: see previous definition of 'NoSuchActionReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(72): warning C4273: 'KAuth::ActionReply::InvalidActionReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(361): note: see previous definition of 'InvalidActionReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(76): warning C4273: 'KAuth::ActionReply::AuthorizationDeniedReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(362): note: see previous definition of 'AuthorizationDeniedReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(80): warning C4273: 'KAuth::ActionReply::UserCancelledReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(363): note: see previous definition of 'UserCancelledReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(84): warning C4273: 'KAuth::ActionReply::HelperBusyReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(364): note: see previous definition of 'HelperBusyReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(88): warning C4273: 'KAuth::ActionReply::AlreadyStartedReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(365): note: see previous definition of 'AlreadyStartedReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(92): warning C4273: 'KAuth::ActionReply::DBusErrorReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(366): note: see previous definition of 'DBusErrorReply'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(98): warning C4273: 'KAuth::ActionReply::ActionReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(412): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(103): warning C4273: 'KAuth::ActionReply::ActionReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(385): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(110): warning C4273: 'KAuth::ActionReply::ActionReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(398): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(117): warning C4273: 'KAuth::ActionReply::ActionReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(409): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(124): warning C4273: 'KAuth::ActionReply::~ActionReply': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(415): note: see previous definition of '{dtor}'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(128): warning C4273: 'KAuth::ActionReply::setData': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(425): note: see previous definition of 'setData'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(133): warning C4273: 'KAuth::ActionReply::addData': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(450): note: see previous definition of 'addData'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(138): warning C4273: 'KAuth::ActionReply::data': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(436): note: see previous definition of 'data'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(143): warning C4273: 'KAuth::ActionReply::type': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(453): note: see previous definition of 'type'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(148): warning C4273: 'KAuth::ActionReply::setType': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(470): note: see previous definition of 'setType'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(153): warning C4273: 'KAuth::ActionReply::succeeded': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(473): note: see previous definition of 'succeeded'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(158): warning C4273: 'KAuth::ActionReply::failed': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(476): note: see previous definition of 'failed'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(163): warning C4273: 'KAuth::ActionReply::errorCode': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(498): note: see previous definition of 'errorCode'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(168): warning C4273: 'KAuth::ActionReply::setErrorCode': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(524): note: see previous definition of 'setErrorCode'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(176): warning C4273: 'KAuth::ActionReply::error': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(487): note: see previous definition of 'error'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(181): warning C4273: 'KAuth::ActionReply::setError': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(512): note: see previous definition of 'setError'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(186): warning C4273: 'KAuth::ActionReply::errorDescription': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(536): note: see previous definition of 'errorDescription'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(191): warning C4273: 'KAuth::ActionReply::setErrorDescription': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(546): note: see previous definition of 'setErrorDescription'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(196): warning C4273: 'KAuth::ActionReply::serialized': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(556): note: see previous definition of 'serialized'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(206): warning C4273: 'KAuth::ActionReply::deserialize': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(566): note: see previous definition of 'deserialize'
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(218): warning C4273: 'KAuth::ActionReply::operator =': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(569): note: see previous definition of '='
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(229): warning C4273: 'KAuth::ActionReply::operator ==': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(586): note: see previous definition of '=='
C:\Craft\_\d6b2a56\kauth\src\kauthactionreply.cpp(234): warning C4273: 'KAuth::ActionReply::operator !=': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthactionreply.h(593): note: see previous definition of '!='
[ 55%] Building CXX object autotests/CMakeFiles/kauth_tests_static.dir/__/src/kauthexecutejob.cpp.obj
kauthexecutejob.cpp
C:\Craft\_\d6b2a56\kauth\src\kauthexecutejob.cpp(53): warning C4273: 'KAuth::ExecuteJob::ExecuteJob': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(53): note: see previous definition of '{ctor}'
C:\Craft\_\d6b2a56\kauth\src\kauthexecutejob.cpp(69): warning C4273: 'KAuth::ExecuteJob::~ExecuteJob': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(69): note: see previous definition of '{dtor}'
C:\Craft\_\d6b2a56\kauth\src\kauthexecutejob.cpp(74): warning C4273: 'KAuth::ExecuteJob::action': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(82): note: see previous definition of 'action'
C:\Craft\_\d6b2a56\kauth\src\kauthexecutejob.cpp(79): warning C4273: 'KAuth::ExecuteJob::data': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(95): note: see previous definition of 'data'
C:\Craft\_\d6b2a56\kauth\src\kauthexecutejob.cpp(84): warning C4273: 'KAuth::ExecuteJob::start': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(77): note: see previous definition of 'start'
C:\Craft\_\d6b2a56\kauth\src\kauthexecutejob.cpp(110): warning C4273: 'KAuth::ExecuteJob::kill': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(108): note: see previous definition of 'kill'
C:\Craft\_\ac4ed36b\RelWithDebInfo-master\autotests\kauth_tests_static_autogen\include\moc_kauthexecutejob.cpp(110): warning C4273: 'KAuth::ExecuteJob::qt_static_metacall': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(51): note: see previous definition of 'qt_static_metacall'
C:\Craft\_\ac4ed36b\RelWithDebInfo-master\autotests\kauth_tests_static_autogen\include\moc_kauthexecutejob.cpp(159): warning C4273: 'staticMetaObject': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(51): note: see previous definition of 'public: static QMetaObject const KAuth::ExecuteJob::staticMetaObject'
C:\Craft\_\ac4ed36b\RelWithDebInfo-master\autotests\kauth_tests_static_autogen\include\moc_kauthexecutejob.cpp(159): error C2491: 'KAuth::ExecuteJob::staticMetaObject': definition of dllimport static data member not allowed
C:\Craft\_\ac4ed36b\RelWithDebInfo-master\autotests\kauth_tests_static_autogen\include\moc_kauthexecutejob.cpp(170): warning C4273: 'KAuth::ExecuteJob::metaObject': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(51): note: see previous definition of 'metaObject'
C:\Craft\_\ac4ed36b\RelWithDebInfo-master\autotests\kauth_tests_static_autogen\include\moc_kauthexecutejob.cpp(175): warning C4273: 'KAuth::ExecuteJob::qt_metacast': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(51): note: see previous definition of 'qt_metacast'
C:\Craft\_\ac4ed36b\RelWithDebInfo-master\autotests\kauth_tests_static_autogen\include\moc_kauthexecutejob.cpp(183): warning C4273: 'KAuth::ExecuteJob::qt_metacall': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(51): note: see previous definition of 'qt_metacall'
C:\Craft\_\ac4ed36b\RelWithDebInfo-master\autotests\kauth_tests_static_autogen\include\moc_kauthexecutejob.cpp(201): warning C4273: 'KAuth::ExecuteJob::newData': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(124): note: see previous definition of 'newData'
C:\Craft\_\ac4ed36b\RelWithDebInfo-master\autotests\kauth_tests_static_autogen\include\moc_kauthexecutejob.cpp(208): warning C4273: 'KAuth::ExecuteJob::statusChanged': inconsistent dll linkage
c:\craft\_\d6b2a56\kauth\src\kauthexecutejob.h(130): note: see previous definition of 'statusChanged'
NMAKE : fatal error U1077: 'C:\PROGRA~2\MICROS~1\2017\PROFES~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\nmake.exe"' : return code '0x2'
Stop.
Action: compile for kde/frameworks/tier2/kauth:master FAILED
*** Task: compile for kde/frameworks/tier2/kauth stopped after: 39 seconds ***
*** Craft all failed: kde/frameworks/tier2/kauth after 39 seconds ***
*** Task: HandlePackage kde/frameworks/tier2/kauth stopped after: 39 seconds ***
fatal error: package kde/frameworks/tier2/kauth all failed
This revision now requires changes to proceed.Feb 9 2019, 3:44 PM
kossebau added a comment.Feb 9 2019, 4:22 PM

Given the autotests reuse the source files from the lib (and thus also using the headers) the export macros confuse windows here.

So in autotests/CMakeLists,txt, one needs to extend

target_compile_definitions(kauth_tests_static PUBLIC KAUTH_STATIC_DEFINE=1)

into

target_compile_definitions(kauth_tests_static PUBLIC KAUTHCORE_STATIC_DEFINE=1 PUBLIC KAUTH_STATIC_DEFINE=1)

Cmp. the generated src/kauthcore_export.h in case you wonder how this (assumingly) fixes things :)

kossebau added a comment.Feb 13 2019, 12:17 AM

Given this seems stuck by missing reviewers, IMHO time to test the fix by try & error on the CI. If no-one would dare to do this, would take over, given I got pulled in and now this unsolved thing steals my attention time ;)

bcooksley added a subscriber: bcooksley.Feb 13 2019, 9:31 AM

@kossebau Please go ahead with testing via trial and error in this manner.

This revision was not accepted when it landed; it landed in state Needs Revision.Feb 13 2019, 3:02 PM
Closed by commit R283:c0854de284b7: Fix Windows build [hopefully] (authored by aacid, committed by kossebau). · Explain Why
This revision was automatically updated to reflect the committed changes.
kossebau added a comment.Feb 13 2019, 3:13 PM

Good news, kauth now passed at least CI again for all platforms tested there (so incl. Windows) :) Your iniail fix was almost complete, @aacid, just missed that last bit for the autotests code, so take pride here :)

Revision Contents
Changeset List

Diff 51593

View Options

autotests/BackendsManager.h

Loading...
View Options

autotests/CMakeLists.txt

Loading...
View Options

src/BackendsManager.h

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/kauthaction.h

Loading...
View Options

src/kauthactionreply.h

Loading...
View Options

src/kauthexecutejob.h

Loading...
View Options

src/kauthhelpersupport.h

Loading...