In Loader::createSpeller, retun early if lang isn't one of the available
languages(); otherwise a dud entry will be created for it in
dictionarycombobox.
Emit a signal when loading a dictionary fails, so that Ui parts can
display an appropriate error message informing the user about the issue,
instead of failing silently.
This is a first step to fix bug 325541.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 8225 | |
| Build 8243: arc lint + arc unit |
I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me.
I would appreciate a comment what the "lang" param is and that "lang" is "language", we don't need to shorten that in the API.
Code-wise:
Could you not just use "find" on the d->languageClients and check the iterator? That way we avoid searching twice (in different data structures).
The this pointer of Loader::createSpeller is const, so the signal has to be const.
In member function ‘Sonnet::SpellerPlugin* Sonnet::Loader::createSpeller(const QString&, const QString&) const’:
/home/ahmad/rpmbuild/kf5-sonnet/git/src/core/loader.cpp:98:43: error: passing ‘const Sonnet::Loader’ as ‘this’ argument discards qualifiers [-fpermissive]
emit loadingDictionaryFailed(plang);I would appreciate a comment what the "lang" param is and that "lang" is "language", we don't need to shorten that in the API.
Yes, of course.
Code-wise:
Could you not just use "find" on the d->languageClients and check the iterator? That way we avoid searching twice (in different data structures).
Makes, much, more sense. Will do.
Improve api docs.
Use constFind() with languageClients, as that's more efficient than searching two separate data structures.