Differential D18946

Set parent on newly created fwupd resource
ClosedPublic
Actions

Authored by leinir on Feb 12 2019, 10:33 AM.

Details

Reviewers
apol
ngraham
Group Reviewers
Discover Software Store
Commits
R134:baac08a40851: Set parent on newly created fwupd resource
R134:8c673e79ab45: Set parent on newly created fwupd resource
Summary

Without this patch, the resource lacks a parent backend, which causes issues when attempting to signal changes in it later on (as AbstractResource depends on there being a backend set)

BUG:402328

Diff Detail

Repository
R134 Discover Software Store
Lint
Lint Skipped
Unit
Unit Tests Skipped
leinir created this revision.Feb 12 2019, 10:33 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 12 2019, 10:33 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Feb 12 2019, 10:33 AM
leinir edited the summary of this revision. (Show Details)
leinir updated this revision to Diff 51482.Feb 12 2019, 10:43 AM

Slightly different (and more central) approach. This ensures that resources are parented on creation rather than later (such as when being added to the updates list)

apol accepted this revision.Feb 12 2019, 10:50 AM
This revision is now accepted and ready to land.Feb 12 2019, 10:50 AM
Closed by commit R134:8c673e79ab45: Set parent on newly created fwupd resource (authored by leinir). · Explain WhyFeb 12 2019, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51482

View Options

libdiscover/backends/FwupdBackend/FwupdBackend.h

Loading...
View Options

libdiscover/backends/FwupdBackend/FwupdBackend.cpp

Loading...