Differential D18820

Change in plugins/CMakeLists.txt It was changed because QML files weren't appearing on QtCreator
ClosedPublic
Actions

Authored by karinapassos on Feb 7 2019, 5:44 PM.

Details

Reviewers
tcanabrava
apol
Group Reviewers
KDE Edu
Commits
R325:88cbe101d3e7: Change in plugins/CMakeLists.txt It was changed because QML files weren't…

Diff Detail

Repository
R325 KAlgebra
Branch
addQmlFilesToCMake
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8033
Build 8051: arc lint + arc unit
karinapassos created this revision.Feb 7 2019, 5:44 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 7 2019, 5:44 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
karinapassos requested review of this revision.Feb 7 2019, 5:44 PM
apol added inline comments.Feb 8 2019, 10:46 AM
mobile/plugins/CMakeLists.txt
11

These won't be installed now, will they?

mobile/plugins/widgets/CMakeLists.txt
7

Why's this change?

karinapassos updated this revision to Diff 51189.EditedFeb 8 2019, 3:38 PM
  • Reduce duplication, use the cmake variable and removing an empty line.
tcanabrava accepted this revision.Feb 8 2019, 3:45 PM
tcanabrava added inline comments.
mobile/plugins/CMakeLists.txt
11

karina, use this same QML_SRC variables in the install command please.

mobile/plugins/widgets/CMakeLists.txt
7

her editor had a 'add new line at the end of file' configuration checked.

This revision is now accepted and ready to land.Feb 8 2019, 3:45 PM
Closed by commit R325:88cbe101d3e7: Change in plugins/CMakeLists.txt It was changed because QML files weren't… (authored by karinapassos, committed by tcanabrava). · Explain WhyFeb 8 2019, 3:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51189

View Options

mobile/plugins/CMakeLists.txt

Loading...
View Options

mobile/plugins/widgets/CMakeLists.txt

Loading...