Differential D18814

Clarify the label of the Shell KRunner.
AbandonedPublic
Actions

Authored by vpilo on Feb 7 2019, 2:01 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Plasma
Summary

This makes sure the end result of the consequence of clicking this runner's results (running a shell command).

Diff Detail

Repository
R120 Plasma Workspace
Branch
vpilo/clarifyKRunnerShell (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7982
Build 8000: arc lint + arc unit
vpilo created this revision.Feb 7 2019, 2:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 7 2019, 2:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
vpilo requested review of this revision.Feb 7 2019, 2:01 PM
davidedmundson added a subscriber: davidedmundson.Feb 7 2019, 2:05 PM

It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run "

vpilo added a comment.Feb 7 2019, 2:06 PM
In D18814#407083, @davidedmundson wrote:

It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run "

"Run %1 in a shell" then?

ngraham requested changes to this revision.Feb 7 2019, 2:07 PM
ngraham added a subscriber: ngraham.

By making this label long, the available room for the command itself is correspondingly reduced, and this UI already has a limited amount of horizontal space. It's probably worse for other languages.

I think the current string is fine given that it says "Command line" to the left.

This revision now requires changes to proceed.Feb 7 2019, 2:07 PM
davidedmundson added a comment.Feb 7 2019, 2:07 PM

What problem are we solving?

If someone said "in a shell" I would expect to see a terminal (a shell) appear. That's not the case.

vpilo abandoned this revision.Feb 7 2019, 2:13 PM
In D18814#407090, @davidedmundson wrote:

What problem are we solving?

If someone said "in a shell" I would expect to see a terminal (a shell) appear. That's not the case.

I thought an inexperienced user could be helped by a more precise outlining of the result.

In D18814#407087, @ngraham wrote:

By making this label long, the available room for the command itself is correspondingly reduced, and this UI already has a limited amount of horizontal space. It's probably worse for other languages.

I think the current string is fine given that it says "Command line" to the left.

Fair enough.

Revision Contents
Changeset List

PathPackages
Mrunners/shell/shellrunner.cpp (2 lines)

Diff 51100

View Options

runners/shell/shellrunner.cpp

Loading...