Add ebook thumbnailer
ClosedPublic

Authored by broulik on Feb 4 2019, 9:30 PM.

Details

Summary

This can extract thumbnails from epub and fb2 ("fiction book", both zipped and unzipped) files.

FEATURE: 200017
FIXED-IN: 19.04.0

Test Plan

Diff Detail

Repository
R320 KIO Extras
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 4 2019, 9:30 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 4 2019, 9:30 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Feb 4 2019, 9:30 PM
ngraham edited the summary of this revision. (Show Details)Feb 4 2019, 9:33 PM
ngraham edited the test plan for this revision. (Show Details)

Works great for most of my ePubs. Here's an archive of some public-domain books in my collection that don't work.

thumbnail/ebookthumbnail.desktop
4

How about "eBooks" or "eBook Files" (a more common term, and all the other entries are plural)

abetts added a subscriber: abetts.Feb 4 2019, 10:20 PM

+1

Awesome!

broulik updated this revision to Diff 50896.Feb 4 2019, 10:54 PM
  • Resolve path to cover relative to OPF file
  • Search for iTunesArtwork as fallback
  • Search for any file *cover* as fallback

Quite lovely. With the latest changes, this now generates thumbnails for all my my ePubs that have a cover page defined.

ngraham accepted this revision as: VDG.Feb 5 2019, 3:58 PM

VDG,approved, still needs a proper code review.

LGTM

thumbnail/CMakeLists.txt
265

PLUGIN_INSTALL_DIR is deprecated, new code should use KDE_INSTALL_PLUGINDIR

broulik updated this revision to Diff 51037.Feb 6 2019, 3:21 PM
  • Use proper cmake thing

do we have a shipit? Looks good to me too!

elvisangelaccio accepted this revision.Feb 6 2019, 9:17 PM
This revision is now accepted and ready to land.Feb 6 2019, 9:17 PM