[effects/startupfeedback] Fix shader
ClosedPublic

Authored by broulik on Feb 5 2019, 11:58 AM.

Details

Summary

Provide both 1.10 and 1.40 shaders.

Test Plan

5.12?

I now get a blinking startup feedback cursor on my machine

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 5 2019, 11:58 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 5 2019, 11:58 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Feb 5 2019, 11:58 AM
zzag requested changes to this revision.Feb 5 2019, 12:08 PM

Please create startupfeedback/data/1.40/blinking-startup-fragment.glsl.

This revision now requires changes to proceed.Feb 5 2019, 12:08 PM
broulik updated this revision to Diff 50940.Feb 5 2019, 12:10 PM
broulik edited the summary of this revision. (Show Details)
zzag added inline comments.Feb 5 2019, 12:14 PM
effects/startupfeedback/data/1.40/blinking-startup-fragment.glsl
1

#version 140

4

in vec2 texcoord0;

out vec4 fragColor;

broulik updated this revision to Diff 50941.Feb 5 2019, 12:15 PM
  • Fix shader
zzag added inline comments.Feb 5 2019, 12:16 PM
effects/startupfeedback/data/1.40/blinking-startup-fragment.glsl
16

gragColor = tex;

16

fragColor

broulik updated this revision to Diff 50942.Feb 5 2019, 12:17 PM
zzag added inline comments.Feb 5 2019, 12:18 PM
effects/startupfeedback/data/1.40/blinking-startup-fragment.glsl
12

Also, I believe "2D" is deprecated, just "texture"

broulik updated this revision to Diff 50943.Feb 5 2019, 12:19 PM

Last fix.

zzag accepted this revision.Feb 5 2019, 12:22 PM
This revision is now accepted and ready to land.Feb 5 2019, 12:22 PM
broulik retitled this revision from Fix blinking startup feedback cursor shader to [effects/startupfeedback] Fix shader.Feb 5 2019, 12:25 PM
This revision was automatically updated to reflect the committed changes.