Differential D18707

[kcmkwin] Remove some name duplication in EffectModel
ClosedPublic
Actions

Authored by zzag on Feb 3 2019, 5:20 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:dc3bc5f7b72b: [kcmkwin] Remove some name duplication in EffectModel
Summary

effect.effectStatus looks very weird.

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7885
Build 7903: arc lint + arc unit
zzag created this revision.Feb 3 2019, 5:20 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 3 2019, 5:20 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 3 2019, 5:20 PM
zzag updated this revision to Diff 50826.Feb 4 2019, 10:22 AM

Rename the role as well.

zzag updated this revision to Diff 50890.Feb 4 2019, 9:15 PM

Rebase.

davidedmundson accepted this revision.Feb 20 2019, 1:02 PM
This revision is now accepted and ready to land.Feb 20 2019, 1:02 PM
Closed by commit R108:dc3bc5f7b72b: [kcmkwin] Remove some name duplication in EffectModel (authored by zzag). · Explain WhyMar 18 2019, 11:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50890

View Options

kcmkwin/common/effectmodel.h

Loading...
View Options

kcmkwin/common/effectmodel.cpp

Loading...
View Options

kcmkwin/kwindesktop/animationsmodel.cpp

Loading...
View Options

kcmkwin/kwineffects/package/contents/ui/Effect.qml

Loading...